GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-31040: Add warning note about mimetypes.add_type ext argument format by OddBloke · Pull Request #2871 · python/cpython

Conversation

@OddBloke

@OddBloke OddBloke commented Jul 25, 2017 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This addresses the documentation of the issue described in bpo-31040,
but not the underlying issue.

https://bugs.python.org/issue31040

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Daniel Watkins
Add warning note about mimetypes.add_type ext argument format
e6571ca 
This addresses the documentation of the issue described in bpo-31040,
but not the underlying issue.
@the-knights-who-say-ni

the-knights-who-say-ni commented Jul 25, 2017

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Jul 25, 2017
@OddBloke OddBloke changed the title Add warning note about mimetypes.add_type ext argument format bpo-31040: Add warning note about mimetypes.add_type ext argument format Jul 25, 2017
@OddBloke

OddBloke commented Jul 25, 2017

Copy link
Copy Markdown
Contributor Author

(I signed the CLA just before submitting this PR, so that should be cleared up fairly soon.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta Mariatta removed the CLA not signed label Jul 26, 2017
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 26, 2017
@brettcannon brettcannon added the awaiting review label Feb 2, 2018
@matrixise matrixise added the docs Documentation in the Doc dir label May 15, 2019
JulienPalard
JulienPalard requested changes Sep 13, 2019
View reviewed changes
Comment thread Doc/library/mimetypes.rst

.. note::

The *ext* argument should start with a dot ("``.``") for the

@JulienPalard JulienPalard Sep 13, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also explicitly tell it can be empty, see b.p.o.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot removed the awaiting review label Sep 13, 2019
@bedevere-bot

bedevere-bot commented Sep 13, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Sep 13, 2019
@csabella

csabella commented Jan 12, 2020

Copy link
Copy Markdown
Contributor

@OddBloke, please address the code review comments from @JulienPalard. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@csabella

csabella commented May 28, 2020

Copy link
Copy Markdown
Contributor

@OddBloke ping
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Feb 20, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 20, 2022
@JelleZijlstra
Merge branch 'main' into docs-for-31040
55f1cab
@JelleZijlstra
JelleZijlstra requested a review from a team as a code owner March 31, 2022 03:49
@JelleZijlstra

JelleZijlstra commented May 8, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Closing as it's been almost three years since the requested change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra closed this May 8, 2022
@OddBloke OddBloke mannequin mentioned this pull request Apr 10, 2022
mimetypes.add_type should complain when you give it an undotted ext #75223
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienPalard JulienPalard JulienPalard requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes docs Documentation in the Doc dir stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@OddBloke @the-knights-who-say-ni @bedevere-bot @csabella @JelleZijlstra @JulienPalard @matrixise @brettcannon @Mariatta
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.