GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-44050: Extension modules can share state when they don't support sub-interpreters. (GH-27794) by ambv · Pull Request #28741 · python/cpython

Conversation

@ambv

@ambv ambv commented Oct 5, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit b9bb748)

Co-authored-by: Hai Shi [email protected]

Note: this is a little different from 3.10 and 3.11 because in 3.10+ _Py_IsMainInterpreter takes PyInterpreterState instead of the entire PyThreadState as an argument (see GH-24577 for that).

Also, the new test uses PyModule_AddObjectRef which was only added in Python 3.10 (see GH-23122). I replaced this usage with the old PyModule_AddObject with additional increfs and decrefs per what BPO-42327 prescribes.

https://bugs.python.org/issue44050

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shihai1991 @ambv
[3.9] bpo-44050: Extension modules can share state when they don't su…
b83a4ff 
…pport sub-interpreters. (pythonGH-27794)

Automerge-Triggered-By: GH:encukou.
(cherry picked from commit b9bb748)

Co-authored-by: Hai Shi <[email protected]>
@ambv
ambv requested review from brettcannon, encukou, ericsnowcurrently, ncoghlan and warsaw as code owners October 5, 2021 16:34
@bedevere-bot bedevere-bot added the awaiting core review label Oct 5, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 5, 2021
@bedevere-bot bedevere-bot mentioned this pull request Oct 5, 2021
bpo-44050: Extension modules can share state when they don't support sub-interpreters. #27794
Merged
@ambv
Replace the non-existent PyModule_AddObjectRef with PyModule_AddObject
f53acff
@ambv
ambv merged commit 52d9d3b into python:3.9 Oct 5, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Oct 5, 2021
@ambv
ambv deleted the backport-b9bb748-3.9 branch October 5, 2021 20:41
@encukou

encukou commented Oct 12, 2021

Copy link
Copy Markdown
Member

Thanks for taking this, Łukasz!
(I would only get to it now ☺)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka mentioned this pull request Nov 15, 2022
C API: Add PyModule_Add() function #86493
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@encukou encukou Awaiting requested review from encukou encukou is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ambv @encukou @the-knights-who-say-ni @bedevere-bot @shihai1991
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.