GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-16379: Fix SQLite version checks in test_module_constants() by erlend-aasland · Pull Request #28809 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Oct 7, 2021 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue16379

Automerge-Triggered-By: GH:pablogsal

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
SQLite version is sqlite3.sqlite_version_info, not sqlite3.version_info
9c45241
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner October 7, 2021 19:19
@bedevere-bot bedevere-bot added the awaiting review label Oct 7, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 7, 2021
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Oct 7, 2021
@erlend-aasland
erlend-aasland requested a review from pablogsal October 7, 2021 19:19
@erlend-aasland erlend-aasland added the skip news label Oct 7, 2021
@erlend-aasland

erlend-aasland commented Oct 7, 2021

Copy link
Copy Markdown
Contributor Author

@pablogsal Can I reuse issue 16379 for this, or is the skip issue label ok here?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Oct 7, 2021

Copy link
Copy Markdown
Contributor Author

GH-27786 (which introduced these tests) was run multiple times with the buildbots. There is apparently too little variation of SQLite versions in the buildbots.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Oct 7, 2021

Copy link
Copy Markdown
Member

@pablogsal Can I reuse issue 16379 for this, or is the skip issue label ok here?

You can reuse the issue if you wish :)
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes Oct 7, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 7, 2021
@pablogsal pablogsal changed the title Fix SQLite version checks in test_module_constants() bpo-16379: Fix SQLite version checks in test_module_constants() Oct 7, 2021
@pablogsal pablogsal added the 🤖 automerge label Oct 7, 2021
@erlend-aasland

erlend-aasland commented Oct 7, 2021

Copy link
Copy Markdown
Contributor Author

Thanks, Pablo :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Oct 7, 2021

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 8deb7af into python:main Oct 7, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 7, 2021
@erlend-aasland
erlend-aasland deleted the sqlite-fix-version-checks branch October 7, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @pablogsal @miss-islington @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.