GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make getpath.c easier to follow. by ericsnowcurrently · Pull Request #28909 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Oct 12, 2021

Copy link
Copy Markdown
Member

This change helps make getpath.c more understandable and easier to modify. It involves 3 changes:

  • rename some variables/functions
  • calculate stdlib_dir separately
  • track information about various filenames, especially stdlib_dir

I've avoided changing any behavior or exposing internal data that wasn't already. I'm saving that for a follow-up PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 9 commits October 8, 2021 11:19
@ericsnowcurrently
argv0_path -> argv0_dir.
534bb77
@ericsnowcurrently
Add PyCalculatePath.stdlib_dir.
633ce3d
@ericsnowcurrently
Break up prefix_found.
418b590
@ericsnowcurrently
Add more location flags.
53f75e0
@ericsnowcurrently
Add PyCalculatePath.argv0_dir_verified.
26da17a
@ericsnowcurrently
Add PyCalculatePath.extensions.
957c375
@ericsnowcurrently
Add LOCATION_NEAR_LIB.
027d88b
@ericsnowcurrently
Fix the LOCATION_* values.
83171d1
@ericsnowcurrently
Preserve existing behavior.
8566bd3
@ericsnowcurrently
ericsnowcurrently requested a review from zooba October 12, 2021 23:27
@bedevere-bot bedevere-bot added the awaiting core review label Oct 12, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 12, 2021
@serhiy-storchaka
serhiy-storchaka requested a review from vstinner October 14, 2021 18:04
@ericsnowcurrently
ericsnowcurrently removed the request for review from vstinner October 14, 2021 18:24
@ericsnowcurrently

ericsnowcurrently commented Oct 25, 2021

Copy link
Copy Markdown
Member Author

Given @zooba is working on #29041, I'm closing this for now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently ericsnowcurrently closed this Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba Awaiting requested review from zooba
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 will be requested when the pull request is marked ready for review FFY00 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ericsnowcurrently @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.