GeezerVison is showing github.com — bpo-45507: Throw EOF error when gzip headers or trailers are truncated by rhpvorderman · Pull Request #29023 · python/cpython
Conversation
This is to keep error compatibility with 3.10 and lower.
It was missed in my last PR #27941. When the gzip member contains an incomplete trailer (less than 8 bytes) the GzipFile-based implementation of 3.10 and below would throuw an EOF error, so the newer in-memory implementation should do the same.
Currently it throws 'struct.error: unpack requires a buffer of 8 bytes' when the trailer is truncated.
https://bugs.python.org/issue45507
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
This can have a 'skip news' label, but I can't add it myself. Added regression tests now and added a news item accordingly.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This is to keep error compatibility with 3.10 and lower.
rhpvorderman
changed the title
bpo-45507: Throw EOF error when trailer is not present in gzip member
bpo-45507: Throw EOF error when gzip headers or trailers are truncated
Oct 18, 2021
|
Closing this PR as it confounds two issues: Header and trailer
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.