GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||
GeezerVison is showing github.com — bpo-39947: Add PyThreadState_SetTrace() function by vstinner · Pull Request #29121 · python/cpython Conversation
| ||||||||||||||||||
|
PyThreadState_SetProfile() is needed by the Python yappi profiler: Source: https://github.com/sumerc/yappi/blob/8bf7a650066f104f59c3cae4a189ec15e7d51c8c/yappi/_yappi.c#L1258 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
See also discussion at: https://bugs.python.org/issue43760 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
cc @markshannon |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I don't understand well the relationship between |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I'm not sure if yappi can use it directly, since PyThreadState_SetProfile() requires to hold the GIL. But it's more a yappi issue, than an API issue IMO. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I think it would be helpful to add a 3rd column stating which of the trace/profile functions see each event type. In case this isn't pointing to the right place, Doc/c-api/init.rst 1556 or 1616 depending on before/after
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| @@ -0,0 +1,3 @@ | |||
| Add new :c:func:`PyThreadState_SetProfile` and | |||
| :c:func:`PyThreadState_SetTrace` functions to set the profile and the trace | |||
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I would add "(replacing _PyEval_SetProfile)" and "(replacing _PyEval_SetTrace)" since those are likely to be the names people have if they are searching for changes, instead of just reading in advance.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Also mention renaming and move is_tstate_valid to _PyThreadState_CheckConsistency
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
is_tstate_valid() is a static function, it cannot be used outside ceval.c. We don't document changes which don't affected the public C API.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I would add "(replacing _PyEval_SetProfile)" and "(replacing _PyEval_SetTrace)" since those are likely to be the names people have if they are searching for changes, instead of just reading in advance.
Usually, we never mention private functions in the changelog.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
If you consider that the doc should be completed, please open a new issue. I don't see a direct relationship between your comment and my PR adding new functions. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'm not convinced that there are 3rd party Python projects which need and will use this function. I prefer to close this PR for now. I may revisit it later, if more users of this function are discovered. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.