GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45573: Use pkg-config for Modules/Setup by tiran · Pull Request #29164 · python/cpython

Conversation

@tiran

@tiran tiran commented Oct 22, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Use pkg-config and a modified version of
PKG_HAVE_DEFINE_WITH_MODULES to detect compiler flags and libraries
for Modules/Setup.

For now CPython does not use any of the new flags in setup.py. We may
expand the use of pkg-config once we are sure that it works properly on
our target platforms.

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue45573

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added the awaiting core review label Oct 22, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 22, 2021
@tiran
tiran force-pushed the configure_pkgconfig branch 2 times, most recently from 2413d8d to 30f60ac Compare October 22, 2021 16:54
@tiran
tiran requested a review from brettcannon October 22, 2021 16:58
@tiran
tiran force-pushed the configure_pkgconfig branch from 30f60ac to 4f5374f Compare October 25, 2021 18:18
tiran added 5 commits October 26, 2021 12:26
@tiran
bpo-45548: Link shared Setup extensions to pybuilddir
3d0e2e8
``makesetup`` puts shared extensions into ``Modules/`` directory. Create
symlinks from pybuilddir so the extensions can be imported.

Note: It is not possible to use the content of pybuilddir.txt as a build
target. Makefile evaluates target variables in the first pass. The
pybuilddir.txt file does not exist at that point.

Signed-off-by: Christian Heimes <[email protected]>
@tiran
bpo-45573: Use pkg-config for Modules/Setup
afcd74b
Use pkg-config and a modified version of
``PKG_HAVE_DEFINE_WITH_MODULES`` to detect compiler flags and libraries
for ``Modules/Setup``.

For now CPython does not use any of the new flags in setup.py. We may
expand the use of pkg-config once we are sure that it works properly on
our target platforms.

Signed-off-by: Christian Heimes <[email protected]>
@tiran
Add Modules subdirs to SRCDIRS
75b3935
@tiran
Convert Modules/Setup into a template file
32583fa
@tiran
Use AM_CONDITIONALs in Modules/Setup.in
310c4e3
@tiran
tiran force-pushed the configure_pkgconfig branch from 4f5374f to 310c4e3 Compare October 26, 2021 14:53
@tiran
Add makefile vars
1ba9652
@erlend-aasland erlend-aasland mentioned this pull request Nov 11, 2021
bpo-45774: Autoconfiscate SQLite detection (GH-29507) #29507
Merged
@brettcannon
brettcannon removed their request for review November 16, 2021 19:37
@brettcannon

brettcannon commented Nov 16, 2021

Copy link
Copy Markdown
Member

Once this leaves the draft stage and my review is still desired, please feel free to add the review request back.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tiran tiran closed this Dec 8, 2021
@tiran tiran mentioned this pull request Jan 22, 2023
Use pkg-config autoconf macros to detect flags for Modules/Setup #89736
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland will be requested when the pull request is marked ready for review erlend-aasland is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping will be requested when the pull request is marked ready for review emmatyping is a code owner
@itamaro itamaro Awaiting requested review from itamaro itamaro will be requested when the pull request is marked ready for review itamaro is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 will be requested when the pull request is marked ready for review corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tiran @brettcannon @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.