GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-89519: fix incorrect access of class property in pydoc and inspect by akulakov · Pull Request #29239 · python/cpython

Conversation

@akulakov

@akulakov akulakov commented Oct 27, 2021 •
edited by serhiy-storchaka
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue45356

I will add a news entry later today.

  • Issue: Calling help executes @classmethod @property decorated methods #89519

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
akulakov added 2 commits October 27, 2021 09:29
@akulakov
guard against access of classproperties
7226d7d
@akulakov
fix help() and inspect.classify_class_attrs: prevent access of class …
4c78430 
…properties
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 27, 2021
@bedevere-bot bedevere-bot added the awaiting review label Oct 27, 2021
@akulakov
akulakov marked this pull request as draft October 27, 2021 18:25
akulakov added 2 commits October 27, 2021 15:44
@akulakov
also look at MRO and expand test accordingly
d68d0a6
@akulakov
factor out _is_class_property
3cec62f
@akulakov
akulakov marked this pull request as ready for review October 27, 2021 19:55
@akulakov

akulakov commented Oct 27, 2021

Copy link
Copy Markdown
Contributor Author

Ubuntu test failure seems unrelated (cache server 503 resp)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@akulakov
add news entry
9c37c9c
@rhettinger
rhettinger self-requested a review November 19, 2021 08:12
MaxwellDupre
MaxwellDupre approved these changes Apr 18, 2022
View reviewed changes

@MaxwellDupre MaxwellDupre left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran 74 tests in 38.639s
OK (skipped=3)
Looks ok.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Apr 18, 2022
@randolf-scholz randolf-scholz mannequin mentioned this pull request May 6, 2022
Calling help executes @classmethod @property decorated methods #89519
Closed
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@nineteendo

nineteendo commented Jun 18, 2024

Copy link
Copy Markdown
Contributor

Ehm, shouldn't this be closed now that classproperties no longer exist?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Apr 10, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 10, 2026
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 12, 2026
@serhiy-storchaka serhiy-storchaka changed the title bpo-45356: fix incorrect access of class property in pydoc and inspect gh-89519: fix incorrect access of class property in pydoc and inspect Aug 12, 2026
@ambv

ambv commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

This PR is attached to gh-89519, which is already completed: the fix for that issue landed through other changes, and this PR's approach was not taken or has since become obsolete. Closing to cull the number of open pull requests. Do not reopen this pull request without getting a go-ahead from a triager or core developer.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv ambv closed this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger
1 more reviewer
@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@akulakov @nineteendo @ambv @MaxwellDupre @the-knights-who-say-ni @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.