GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] bpo-45438: format of inspect.Signature with generic builtins (GH-29212) by miss-islington · Pull Request #29253 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 27, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Use types.GenericAlias in inspect.formatannotation to correctly add
type arguments of builtin types to the string representation of
Signatures.

Co-authored-by: Martin Rückl [email protected]
(cherry picked from commit d02ffd1)

Co-authored-by: Martin Rueckl [email protected]

https://bugs.python.org/issue45438

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@martinitus @miss-islington
bpo-45438: format of inspect.Signature with generic builtins (pythonG…
de555cb 
…H-29212)

Use types.GenericAlias in inspect.formatannotation to correctly add
type arguments of builtin types to the string representation of
Signatures.

Co-authored-by: Martin Rückl <[email protected]>
(cherry picked from commit d02ffd1)

Co-authored-by: Martin Rueckl <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 27, 2021
@miss-islington

miss-islington commented Oct 27, 2021

Copy link
Copy Markdown
Contributor Author

@martinitus and @gvanrossum: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Oct 27, 2021

Copy link
Copy Markdown
Contributor Author

@martinitus and @gvanrossum: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request Oct 27, 2021
bpo-45438: format of inspect.Signature with generic builtins #29212
Merged
@bedevere-bot bedevere-bot added the awaiting review label Oct 27, 2021
gvanrossum
gvanrossum approved these changes Oct 27, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 27, 2021
@miss-islington

miss-islington commented Oct 27, 2021

Copy link
Copy Markdown
Contributor Author

@martinitus and @gvanrossum: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit ce7a6af into python:3.10 Oct 27, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 27, 2021
@miss-islington
miss-islington deleted the backport-d02ffd1-3.10 branch October 27, 2021 21:57
@rhettinger rhettinger mentioned this pull request Oct 18, 2022
inspect not capturing type annotations created by __class_getitem__ #89601
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @gvanrossum @the-knights-who-say-ni @bedevere-bot @martinitus
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.