GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Header files error fixed by shikharjaiswal-in · Pull Request #29264 · python/cpython

Conversation

@shikharjaiswal-in

@shikharjaiswal-in shikharjaiswal-in commented Oct 28, 2021

Copy link
Copy Markdown

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@shikharjaiswal-in
Add files via upload
8fc6c60
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Oct 28, 2021
@the-knights-who-say-ni

the-knights-who-say-ni commented Oct 28, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@shikhar1020jais1

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added the awaiting review label Oct 28, 2021
@da-woods

da-woods commented Nov 1, 2021

Copy link
Copy Markdown
Contributor

It isn't clear what error you believe you've fixed?

It looks to me like this PR:

  • Adds #ifdef __cplusplus extern "C" { #endifguards. These are mostly unnecessary because they're in the files one level out. For example "include/unicodeobject.h" (which includes include/cpython/unicodeobject.h) already has the extern "C"

    cpython/Include/unicodeobject.h

    Lines 106 to 108 in 14a4fce

    #ifdef __cplusplus
    extern "C" {
    #endif
  • Somehow rewrites every line of the file (probably by changing the line endings??).
  • Creates a copy of pyconfig.h in the include directory
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions

github-actions Bot commented Dec 2, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 2, 2021
@hugovk hugovk mentioned this pull request Feb 17, 2022
Cron job to close stale PRs python/core-workflow#93
Closed
@github-actions

github-actions Bot commented Feb 18, 2022

Copy link
Copy Markdown

Closing this stale PR because the CLA is still not signed.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot closed this Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@shikharjaiswal-in @the-knights-who-say-ni @da-woods @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.