GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45573: Detect stdlib extension modules in configure by tiran · Pull Request #29534 · python/cpython

Conversation

@tiran

@tiran tiran commented Nov 12, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

work in progress

configure now detects if a stdlib extension module is enabled/disabled and all prerequisites are available. Compiler and linker flags are passed to Makefile, makesetup, and setup.py.

For each extension module Makefile now contains up to three additional variables:

MODULE__SSL=yes
MODULE__SSL_CFLAGS=
MODULE__SSL_LDFLAGS=-lssl -lcrypto

Modules/Setup entries use the new variables. An entry like _ssl _ssl.c is sufficient to compile the ssl module as builtin. All compiler and linker flags are set by configure. The MODULE_EGG can be one of yes, disabled, missing, n/a.

Modules/_ssl.o: $(srcdir)/Modules/_ssl.c $(MODULE__SSL_DEPS) $(PYTHON_HEADERS) Modules/config.c
    $(CC) $(CCSHARED) $(PY_CFLAGS_NODIST) $(PY_CPPFLAGS) $(MODULE__SSL_CFLAGS) -c $(srcdir)/Modules/_ssl.c -o Modules/_ssl.o
Modules/_ssl$(EXT_SUFFIX):  Modules/_ssl.o
    $(BLDSHARED)  Modules/_ssl.o $(MODULE__SSL_LDFLAGS)  -o Modules/_ssl$(EXT_SUFFIX)

Missing modules: _curses, _curses_panel, _dbm, _sqlite3, _nis, _ctypes.

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue45573

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran tiran added the DO-NOT-MERGE label Nov 12, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 12, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Nov 12, 2021
@tiran
tiran force-pushed the configure_stdlib branch from bdca469 to 1c959ff Compare November 12, 2021 09:34
erlend-aasland
erlend-aasland reviewed Nov 12, 2021
View reviewed changes
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tiran
tiran force-pushed the configure_stdlib branch from a0fb549 to 15d8b38 Compare November 14, 2021 13:42
tiran added 5 commits November 14, 2021 20:56
@tiran
bpo-45573: Detect stdlib extension modules in configure
207617e 
configure now detects if a stdlib extension module is enabled/disabled
and all prerequisites are available. Compiler and linker flags are
passed to Makefile, makesetup, and setup.py.

Missing modules: _curses, _curses_panel, _dbm, _sqlite3, _nis, _ctypes.

Signed-off-by: Christian Heimes <[email protected]>
@tiran
Generate MODULE_BLOCK automatically
bcf8469
@tiran
Generate block for simple and static modules
7b0d162
@tiran
Split enabled/supported flags
513ff43
@tiran
Use CFLAGS, LDFLAGS, and DEPS from Makefile
836eb43
@tiran
tiran force-pushed the configure_stdlib branch from 15d8b38 to 836eb43 Compare November 14, 2021 20:11
tiran added 3 commits November 15, 2021 08:56
@tiran
Comment out some modules that are not ported yet
c4311ad
@tiran
Simplify setup.py even more
61f31c1
@tiran
Add Setup.stdlib
d8ab7c8
@tiran tiran mentioned this pull request Nov 17, 2021
bpo-45774: Autoconfiscate SQLite detection (GH-29507) #29507
Merged
@github-actions

github-actions Bot commented Dec 18, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 18, 2021
@tiran tiran closed this Jun 30, 2022
@tiran tiran mentioned this pull request Jan 22, 2023
Use pkg-config autoconf macros to detect flags for Modules/Setup #89736
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping will be requested when the pull request is marked ready for review emmatyping is a code owner
@itamaro itamaro Awaiting requested review from itamaro itamaro will be requested when the pull request is marked ready for review itamaro is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 will be requested when the pull request is marked ready for review corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review DO-NOT-MERGE stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tiran @erlend-aasland @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.