GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-20849: allow existing directory in shutil.copytree by ofek · Pull Request #2977 · python/cpython

Conversation

@ofek

@ofek ofek commented Aug 1, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This is a legacy thing that wasn't updated with https://docs.python.org/3/library/os.html#os.makedirs

https://bugs.python.org/issue20849

Let us not bikeshed this time!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TheJJ, dh-nunes, nooperpudd, olivier-grech, and twosigmajab reacted with thumbs up emoji
All reactions
  • 👍 5 reactions
@ofek
allow existing directory in shutil.copytree
5362eba 
This is a legacy thing that wasn't updated with https://docs.python.org/3/library/os.html#os.makedirs
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 1, 2017
@ofek ofek changed the title allow existing directory in shutil.copytree bpo-20849: allow existing directory in shutil.copytree Aug 1, 2017
@olivier-grech

olivier-grech commented Feb 1, 2018

Copy link
Copy Markdown

Should not we update the docstring too? Especially the The destination directory must not already exist. part.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@matrixise

matrixise commented Feb 1, 2018

Copy link
Copy Markdown
Member

make sense
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon brettcannon added the awaiting review label Feb 2, 2018
@jnnnnn

jnnnnn commented Mar 15, 2018

Copy link
Copy Markdown

I need this!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ned-deily

ned-deily commented Jun 7, 2018

Copy link
Copy Markdown
Member

@ofek Thanks for the PR and sorry that it has languished. But the PR cannot be accepted as is for two reasons: one, it ignores the discussion on the bug tracker about why changing the semantics of shutil.copytree to unconditionally ignore existing destination directories may be problematic; and two, we require PRs to be submitted against the cpython master branch, not a maintenance branch like 3.6; if a core developer decides to accept and merge a PR against master, they will decide whether any backports to maintenance branches are appropriate. Thus, I am closing the PR against 3.6. If you are still interested in pursuing this, perhaps making a new PR against master from the originally submitted patch might be a way forward.

https://devguide.python.org/#status-of-python-branches
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ned-deily ned-deily closed this Jun 7, 2018
@ofek
ofek deleted the patch-1 branch June 7, 2018 04:37
@jab jab mentioned this pull request Aug 16, 2018
bpo-20849: add dirs_exist_ok to shutil.copytree #8792
Merged
@jab

jab commented Aug 16, 2018

Copy link
Copy Markdown
Contributor

Hi @ned-deily, I picked this back up in #8792 and addressed the outstanding concerns here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@ofek @olivier-grech @matrixise @jnnnnn @ned-deily @jab @brettcannon @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.