GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40280: Disable unusable core extension modules on emscripten (GH-29834) by erlend-aasland · Pull Request #29834 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Nov 29, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Based on emmatyping/python-wasm#10 (comment)

Fixes emmatyping/python-wasm#10

Co-authored-by: Christian Heimes [email protected]

https://bugs.python.org/issue40280

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
erlend-aasland requested a review from tiran November 29, 2021 10:23
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 29, 2021
@bedevere-bot bedevere-bot added the awaiting review label Nov 29, 2021
@erlend-aasland
erlend-aasland requested a review from brettcannon November 29, 2021 10:23
tiran
tiran reviewed Nov 29, 2021
View reviewed changes
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend E. Aasland @tiran
bpo-40280: Disable unusable core extension modules on emscripten
7e328d2 
Based on emmatyping/python-wasm#10 (comment)

Co-authored-by: Christian Heimes <[email protected]>
@erlend-aasland
erlend-aasland force-pushed the ac-emscripten-mods branch from f66cd77 to 7e328d2 Compare November 29, 2021 10:27
@erlend-aasland
erlend-aasland requested a review from tiran November 29, 2021 10:57
emmatyping
emmatyping approved these changes Nov 29, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Nov 29, 2021
@tiran

tiran commented Nov 29, 2021

Copy link
Copy Markdown
Member

@ethanhs is the list sensible?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@emmatyping

emmatyping commented Nov 29, 2021

Copy link
Copy Markdown
Member

@ethanhs is the list sensible?

Yes, I think so. It is possible we may add or remove things down the line, but I think this is a good list as far as I am aware of things.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran tiran changed the title bpo-40280: Disable unusable core extension modules on emscripten bpo-40280: Disable unusable core extension modules on emscripten (GH-29834) Nov 29, 2021
@tiran
tiran merged commit b3f443a into python:main Nov 29, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 29, 2021
@erlend-aasland
erlend-aasland deleted the ac-emscripten-mods branch November 29, 2021 11:58
@SimonBiggs SimonBiggs mannequin mentioned this pull request Jun 7, 2022
Consider supporting emscripten/webassembly as a build target #84461
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmatyping emmatyping emmatyping approved these changes
@brettcannon brettcannon Awaiting requested review from brettcannon
@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Disable unusable core extension module

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @tiran @emmatyping @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.