GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40280: Emscripten defaults to --with-ensurepip=no (GH-29873) by tiran · Pull Request #29873 · python/cpython

Conversation

@tiran

@tiran tiran commented Dec 1, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Reduces installation size of browser bundle

https://bugs.python.org/issue40280

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
bpo-40280: Emscripten defaults to --with-ensurepip=no
4f8cc1a 
Reduces installation size of browser bundle

Signed-off-by: Christian Heimes <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 1, 2021
@tiran
tiran force-pushed the bpo-40280-ensurepip branch from 9678387 to 4f8cc1a Compare December 1, 2021 08:11
@bedevere-bot bedevere-bot added the awaiting core review label Dec 1, 2021
@tiran tiran added the skip news label Dec 1, 2021
@tiran
tiran requested a review from brettcannon December 1, 2021 11:13
emmatyping
emmatyping reviewed Dec 1, 2021
View reviewed changes
Comment thread configure.ac
[with_ensurepip=upgrade])
[
AS_CASE([$ac_sys_system],
[Emscripten], [$with_ensurepip=no],

@emmatyping emmatyping Dec 1, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we disable ensurepip for WASI as well?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@tiran tiran Dec 1, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to wait until we have WASI builds working and more experience with WASI.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
emmatyping reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
brettcannon
brettcannon approved these changes Dec 1, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Dec 1, 2021
@tiran tiran changed the title bpo-40280: Emscripten defaults to --with-ensurepip=no bpo-40280: Emscripten defaults to --with-ensurepip=no (GH-29873) Dec 1, 2021
@tiran
tiran merged commit 9deb834 into python:main Dec 1, 2021
@tiran
tiran deleted the bpo-40280-ensurepip branch December 1, 2021 19:43
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 1, 2021
@SimonBiggs SimonBiggs mannequin mentioned this pull request Jun 7, 2022
Consider supporting emscripten/webassembly as a build target #84461
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmatyping emmatyping emmatyping left review comments
@brettcannon brettcannon brettcannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@tiran @brettcannon @emmatyping @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.