GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40280: Emscripten with_ensurepip=no, second attempt (GH-29884) by tiran · Pull Request #29884 · python/cpython

Conversation

@tiran

@tiran tiran commented Dec 1, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue40280

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
bpo-40280: Emscripten with_ensurepip=no, second attempt
743c21c
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 1, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Dec 1, 2021
@tiran tiran added skip news and removed awaiting core review labels Dec 1, 2021
@tiran

tiran commented Dec 1, 2021

Copy link
Copy Markdown
Member Author

I forgot to remove --with-ensurepip=no from the build script when I tested the first patch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran
tiran requested a review from brettcannon December 1, 2021 21:04
brettcannon
brettcannon approved these changes Dec 1, 2021
View reviewed changes
@bedevere-bot bedevere-bot added the awaiting merge label Dec 1, 2021
@brettcannon

brettcannon commented Dec 1, 2021

Copy link
Copy Markdown
Member

Shows how valuable my reviews are 😅
tiran reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran

tiran commented Dec 1, 2021

Copy link
Copy Markdown
Member Author

Shows how valuable my reviews are sweat_smile

We need CI :)
brettcannon reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran tiran changed the title bpo-40280: Emscripten with_ensurepip=no, second attempt bpo-40280: Emscripten with_ensurepip=no, second attempt (GH-29884) Dec 1, 2021
@tiran
tiran merged commit 309110f into python:main Dec 1, 2021
@tiran
tiran deleted the bpo-40280-ensurepip2 branch December 1, 2021 22:16
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 1, 2021
@tiran tiran mentioned this pull request Dec 2, 2021
Make --with-ensurepip=no the default upstream emmatyping/python-wasm#23
Closed
@SimonBiggs SimonBiggs mannequin mentioned this pull request Jun 7, 2022
Consider supporting emscripten/webassembly as a build target #84461
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tiran @brettcannon @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.