GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-45897: Fix frozen-slotted dataclass bug by AlexWaygood · Pull Request #29895 · python/cpython

Conversation

AlexWaygood commented Dec 2, 2021 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

https://bugs.python.org/issue45897

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          bpo-45897: Fix frozen-slotted dataclass bug

9c36be6

AlexWaygood requested a review from ericvsmith as a code owner

December 2, 2021 17:20

the-knights-who-say-ni added the CLA signed label

Dec 2, 2021

bedevere-bot added the awaiting review label

Dec 2, 2021

AlexWaygood added the type-bug An unexpected behavior, bug, or error label

Dec 6, 2021


          Tweak test

e968679

arhadthedev reviewed

Dec 15, 2021

View reviewed changes

Comment thread

Lib/test/test_dataclasses.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood added 3 commits

December 15, 2021 14:40


          Address review

df2216b


          Add further clarification

a71575f


          Add more comments

eda3c7f

erlend-aasland reviewed

Dec 16, 2021

View reviewed changes

Comment thread

Lib/test/test_dataclasses.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_dataclasses.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_dataclasses.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_dataclasses.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood and others added 3 commits

December 16, 2021 22:37


          Update Lib/test/test_dataclasses.py

9af7074

Co-authored-by: Erlend Egeberg Aasland <[email protected]>


          Update Lib/test/test_dataclasses.py

9f8c91c

Co-authored-by: Erlend Egeberg Aasland <[email protected]>


          Add comment

ce675c5

erlend-aasland reviewed

Dec 16, 2021

View reviewed changes

Comment thread

Lib/test/test_dataclasses.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood added 2 commits

December 16, 2021 23:00


          Use self.assertRaisesRegex, since Erlend insists ;)

007a596


          79-character wrap

bea4c9d

AlexWaygood added the needs backport to 3.10 label

Dec 19, 2021

JelleZijlstra reviewed

Jan 24, 2022

View reviewed changes

Comment thread

Lib/dataclasses.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood marked this pull request as draft

January 24, 2022 07:48

AlexWaygood marked this pull request as ready for review

January 24, 2022 19:20

JelleZijlstra approved these changes

Feb 17, 2022

View reviewed changes

JelleZijlstra left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but will leave to @ericvsmith to merge.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

Lib/dataclasses.py

		# Frozen __setattr__/__delattr__ must be added after __slots__
		# bpo-45897
		if frozen:
		for fn in _frozen_get_del_attr(cls, field_list, globals):

JelleZijlstra Feb 17, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this function ought to be named _frozen_set_del_attr. That's outside the scope of this PR though.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood reacted with thumbs up emoji

All reactions

👍 1 reaction

bedevere-bot added awaiting merge and removed awaiting review labels

Feb 17, 2022

JelleZijlstra commented Apr 13, 2022

Copy link

Copy Markdown

Member

@ericvsmith could you take a look at this PR?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ericvsmith commented Apr 13, 2022

Copy link

Copy Markdown

Member

Thanks for the reminder. This is one of the things I'll be reviewing at PyCon.

JelleZijlstra and AlexWaygood reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood and others added 4 commits

April 24, 2022 22:47


          Merge branch 'main' into dataclass-slots

c93c2be


          Merge remote-tracking branch 'origin' into dataclass-slots

34c66f3


          Merge branch 'dataclass-slots' of https://github.com/AlexWaygood/cpython

a105c6e

 into dataclass-slots


          Fix trailing whitespace

b7ef7b9


          Merge branch 'main' into dataclass-slots

3d04919

AlexWaygood mentioned this pull request

May 3, 2022

test_concurrent_futures sometimes hangs indefinitely on Windows #92222

Closed

AlexWaygood commented May 3, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

Closing and reopening to retrigger CI, since test_concurrent_futures has been running for 2hr43 and counting on Windows (x86) -- I've opened #92222 since this appears to have happened 3 times in 3 days in our CI.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood closed this

May 3, 2022

AlexWaygood reopened this

May 3, 2022

treyhunner mentioned this pull request

May 3, 2022

Frozen dataclasses with slots raise TypeError #90055

Closed

AlexWaygood added the needs backport to 3.11 only security fixes label

May 8, 2022

AlexWaygood commented Jun 9, 2022

Copy link

Copy Markdown

Member Author

@ericvsmith, any thoughts on this PR? Happy to revise or close if you don't like the approach :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ericvsmith commented Jun 19, 2022

Copy link

Copy Markdown

Member

Sorry it’s taken me so long to look at this, @AlexWaygood. I’ve been super-busy, with no signs of improving. If you don’t hear from me in a two weeks or so, please ping me again.

AlexWaygood reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood commented Jun 19, 2022

Copy link

Copy Markdown

Member Author

Sorry it’s taken me so long to look at this, @AlexWaygood. I’ve been super-busy, with no signs of improving. If you don’t hear from me in a two weeks or so, please ping me again.

Thanks for letting me know @ericvsmith, no worries.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood commented Jul 7, 2022

Copy link

Copy Markdown

Member Author

Sorry it’s taken me so long to look at this, @AlexWaygood. I’ve been super-busy, with no signs of improving. If you don’t hear from me in a two weeks or so, please ping me again.

Ping, @ericvsmith :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ezio-melotti removed the CLA signed label

Jul 13, 2022


          Merge branch 'main' into dataclass-slots

d29551c

AlexWaygood commented Oct 4, 2022

Copy link

Copy Markdown

Member Author

Closing as per @ericvsmith's rationale in #90055 (comment)

markjoshwel reacted with confused emoji

All reactions

😕 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood closed this

Oct 4, 2022

AlexWaygood deleted the dataclass-slots branch

October 4, 2022 17:46

Reviewers

arhadthedev

arhadthedev left review comments

erlend-aasland

erlend-aasland left review comments

JelleZijlstra

JelleZijlstra approved these changes

ericvsmith

Awaiting requested review from ericvsmith

ericvsmith is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge needs backport to 3.11

only security fixes

type-bug

An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

AlexWaygood commented Dec 2, 2021 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JelleZijlstra left a comment

Choose a reason for hiding this comment

Uh oh!

JelleZijlstra Feb 17, 2022

Choose a reason for hiding this comment

Uh oh!

JelleZijlstra commented Apr 13, 2022

Uh oh!

ericvsmith commented Apr 13, 2022

Uh oh!

AlexWaygood commented May 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlexWaygood commented Jun 9, 2022

Uh oh!

ericvsmith commented Jun 19, 2022

Uh oh!

AlexWaygood commented Jun 19, 2022

Uh oh!

AlexWaygood commented Jul 7, 2022

Uh oh!

AlexWaygood commented Oct 4, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

AlexWaygood commented Dec 2, 2021 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood commented May 3, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.