GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45582: Add conditions to isdir/isfile/isxfile in getpath.c by neonene · Pull Request #29906 · python/cpython

Conversation

@neonene

@neonene neonene commented Dec 3, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

It looks to me a NOT(!) operator is missing in getpath_isxfile().
INVALID_FILE_ATTRIBUTES(-1) checks are also added just in case.

https://bugs.python.org/issue45582

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@neonene
Add a NOT operator to the condition in getpath_isxfile
2e87f50
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 3, 2021
@bedevere-bot bedevere-bot added the awaiting review label Dec 3, 2021
@zooba zooba added the skip news label Dec 3, 2021
@zooba
zooba merged commit 7d7c91a into python:main Dec 3, 2021
@bedevere-bot bedevere-bot removed the awaiting review label Dec 3, 2021
@zooba

zooba commented Dec 3, 2021

Copy link
Copy Markdown
Member

Thanks!
neonene reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@neonene
neonene deleted the bpo-45582 branch December 3, 2021 22:15
@zooba zooba mentioned this pull request Apr 10, 2022
Rewrite getpath.c in Python #89745
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@neonene @zooba @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.