GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix missing spaces in os.walk example by BruceLee569 · Pull Request #29918 · python/cpython

Conversation

@BruceLee569

@BruceLee569 BruceLee569 commented Dec 5, 2021

Copy link
Copy Markdown
Contributor

In the example of os.walk, a space is required between each sentence to distinguish words.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@BruceLee569
Update os.py
16459f7 
In the example of os.walk, a space is required between each sentence to distinguish words.
@the-knights-who-say-ni

the-knights-who-say-ni commented Dec 5, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@BruceLee569

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Dec 5, 2021
@bedevere-bot bedevere-bot added the awaiting review label Dec 5, 2021
@github-actions

github-actions Bot commented Jan 5, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 5, 2022
kumaraditya303
kumaraditya303 approved these changes Jan 6, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Jan 6, 2022
@JelleZijlstra JelleZijlstra added skip issue skip news labels Jan 24, 2022
JelleZijlstra
JelleZijlstra approved these changes Jan 24, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest retitling the PR to "Fix missing spaces in os.walk example"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@BruceLee569 BruceLee569 changed the title Update os.py Fix missing spaces in os.walk example Jan 24, 2022
JelleZijlstra
JelleZijlstra approved these changes Feb 17, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Planning to merge in a few days (cc @gvanrossum, another trivial docs fix).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 17, 2022
@JelleZijlstra JelleZijlstra self-assigned this Feb 17, 2022
gvanrossum
gvanrossum reviewed Feb 17, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not big on fixing typos in comments/docstrings (they tend to generate a lot of review noise for very little payback), and the fix here is unrelated to the point of the example. Then again, the damage is already done. I just hope that the contributor fixes something more significant in their next contribution.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk hugovk mentioned this pull request Feb 17, 2022
Cron job to close stale PRs python/core-workflow#93
Closed
@terryjreedy
Simpler fix
e5e5a60
@terryjreedy terryjreedy removed the stale Stale PR or inactive for long period of time. label Feb 17, 2022
terryjreedy
terryjreedy approved these changes Feb 17, 2022
View reviewed changes

@terryjreedy terryjreedy left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that buggy code should be fixed even in docstring and that this does not need CLA. Please merge when CLA passes so we are done with this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@terryjreedy
terryjreedy merged commit 2a38e1a into python:main Feb 18, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum left review comments
@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@terryjreedy terryjreedy terryjreedy approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@BruceLee569 @the-knights-who-say-ni @JelleZijlstra @gvanrossum @terryjreedy @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.