GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45711: Remove unnecessary normalization of exc_info by iritkatriel · Pull Request #29922 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Dec 5, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

exc_info should always be normalized, so it is not necessary to normalize it here.

It is also not necessary to copy the traceback to the exception instance. I added an assertion that the traceback does not change, and it broke only one test: test_exception_chaining_after_await_with_context_cycle

This is a test that raises the same exception twice, and makes sure that no context cycle is created. The test is not concerned with the traceback at all. We discussed the issue of the traceback change in this test in PR29780.

https://bugs.python.org/issue45711

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
bpo-45711: Remove unnecessary normalization of exc_info
7a22e14
@iritkatriel
iritkatriel requested a review from cjerdonek December 5, 2021 17:31
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 5, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Dec 5, 2021
@blurb-it
📜🤖 Added by blurb_it.
ddbb27d
@iritkatriel
iritkatriel requested a review from gvanrossum December 5, 2021 17:37
arhadthedev
arhadthedev reviewed Dec 5, 2021
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2021-12-05-17-36-08.bpo-45711.3TmTSw.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel @arhadthedev
Fix typo in news
0314b71 
Co-authored-by: Oleg Iarygin <[email protected]>
@iritkatriel
iritkatriel requested a review from markshannon December 8, 2021 11:54
gvanrossum
gvanrossum approved these changes Dec 8, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Dec 8, 2021
@iritkatriel
iritkatriel merged commit 2109f78 into python:main Dec 8, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 8, 2021
@iritkatriel
iritkatriel deleted the 45711-exc_info_does_not_need_normalizing-2 branch December 8, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedev arhadthedev arhadthedev left review comments
@gvanrossum gvanrossum gvanrossum approved these changes
@cjerdonek cjerdonek Awaiting requested review from cjerdonek
@markshannon markshannon Awaiting requested review from markshannon

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@iritkatriel @gvanrossum @arhadthedev @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.