GeezerVison is showing github.com — bpo-45582: Fix getpath_isxfile() and test_embed on Windows by neonene · Pull Request #29930 · python/cpython
Conversation
neonene
commented
Dec 6, 2021
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Current getpath_isxfile() in getpath.c always returns false.
After the function is fixed, test_embed.py needs a workaround to pass the following tests that have the same error in the release build.
- test_init_pybuilddir_win32
- test_init_pyvenv_cfg
FAIL: test_init_pybuilddir_win32 (test.test_embed.InitConfigTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "C:\cp\Lib\test\test_embed.py", line 1322, in test_init_pybuilddir_win32
self.check_all_configs("test_init_compat_config", config,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\cp\Lib\test\test_embed.py", line 728, in check_all_configs
self.check_config(configs, expected_config)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\cp\Lib\test\test_embed.py", line 654, in check_config
self.assertEqual(config, expected)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: {'_co[316 chars]embed.exe', ...
...
- 'program_name': './_testembed.exe',
? ----
+ 'program_name': './_testembed',
...
The debug build passes them using the default program_name, and the PGO build does not due to another issue.
https://bugs.python.org/issue45582
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
zooba
zooba approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|