GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45950: Fix macOS framework builds of _bootstrap_python (GH-29936) by tiran · Pull Request #29936 · python/cpython

Conversation

@tiran

@tiran tiran commented Dec 6, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

…g framework

https://bugs.python.org/issue45950

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
tiran requested review from ned-deily and ronaldoussoren December 6, 2021 10:02
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 6, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Dec 6, 2021
@tiran tiran added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Dec 6, 2021
@bedevere-bot

bedevere-bot commented Dec 6, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 02dc19dd98f2eaa19c2de25eb5a48dec857fa7b1 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 6, 2021
@tiran
bpo-45950: Attempt to fix macOS builds of _bootstrap_python when usin…
13e5d43 
…g framework
@tiran
tiran force-pushed the bpo-45950-macos branch from 02dc19d to cb45323 Compare December 6, 2021 13:05
@tiran
Allow --with-build-python for all builds again
0a3a53c
@tiran
tiran force-pushed the bpo-45950-macos branch from cb45323 to 0a3a53c Compare December 6, 2021 13:35
@tiran
tiran marked this pull request as ready for review December 6, 2021 14:19
ambv
ambv approved these changes Dec 6, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Dec 6, 2021
@tiran tiran changed the title bpo-45950: Attempt to fix macOS builds of _bootstrap_python when usin… bpo-45950: Fix macOS framework builds of _bootstrap_python (GH-29936) Dec 6, 2021
@tiran
tiran merged commit 612e59b into python:main Dec 6, 2021
@tiran
tiran deleted the bpo-45950-macos branch December 6, 2021 16:13
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 6, 2021
gvanrossum
gvanrossum reviewed Dec 7, 2021
View reviewed changes
Comment thread Makefile.pre.in
Comment on lines +1208 to +1217
# like getpath.o with additional -DPY_BOOTSTRAP_PYTHON=1
Modules/getpath_bootstrap.o: $(srcdir)/Modules/getpath.c Python/frozen_modules/getpath.h Makefile $(PYTHON_HEADERS)
$(CC) -c $(PY_CORE_CFLAGS) -DPYTHONPATH='"$(PYTHONPATH)"' \
-DPREFIX='"$(prefix)"' \
-DEXEC_PREFIX='"$(exec_prefix)"' \
-DVERSION='"$(VERSION)"' \
-DVPATH='"$(VPATH)"' \
-DPLATLIBDIR='"$(PLATLIBDIR)"' \
-DPY_BOOTSTRAP_PYTHON=1 \
-o $@ $(srcdir)/Modules/getpath.c

@gvanrossum gvanrossum Dec 7, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be more elegant to have a two-line file named getpath_bootstrap.c using the default .c.o rule?

#define BOOTSTRAP_PYTHON 1
#include "getpath.c"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@tiran tiran Dec 7, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the approach is not elegant. getpath.c requires additional macros

cpython/Modules/getpath.c

Lines 24 to 28 in ddbab69

#if (!defined(PREFIX) || !defined(EXEC_PREFIX) \
|| !defined(VERSION) || !defined(VPATH) \
|| !defined(PLATLIBDIR))
#error "PREFIX, EXEC_PREFIX, VERSION, VPATH and PLATLIBDIR macros must be defined"
#endif

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran tiran mentioned this pull request May 9, 2022
Reintroduce bootstrap_python for freezing #90108
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum left review comments
@ambv ambv ambv approved these changes
@ronaldoussoren ronaldoussoren Awaiting requested review from ronaldoussoren
@ned-deily ned-deily Awaiting requested review from ned-deily

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@tiran @bedevere-bot @ambv @gvanrossum @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.