GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45582: Change the folder location of PGO-instrumented builds on Windows by neonene · Pull Request #29941 · python/cpython

Conversation

@neonene

@neonene neonene commented Dec 6, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Current Python cannot find paths correctly at the PGO profiling time.
Even if envvars are set, test_embed fails.

This issue does not exist when the PGO-instrumented build is located as high as the product build in directory level.

https://bugs.python.org/issue45582

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
neonene added 2 commits December 6, 2021 23:05
@neonene
Replace a backslash with an underscore in the dir path
694f67a
@neonene
Change the pgc/pgd filepaths
91ad1c8
@neonene
neonene requested a review from a team as a code owner December 6, 2021 14:23
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 6, 2021
@bedevere-bot bedevere-bot added the awaiting review label Dec 6, 2021
blurb-it Bot and others added 3 commits December 6, 2021 14:25
@blurb-it
📜🤖 Added by blurb_it.
edfbb04
@neonene
correct the news
fa523c5
@neonene
fix news
478184d
@zooba

zooba commented Dec 8, 2021

Copy link
Copy Markdown
Member

It would be good to understand what the change in getpath is that caused this to start breaking, as it may impact other users as well.

That said, I approve of this change anyway.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@neonene

neonene commented Dec 9, 2021

Copy link
Copy Markdown
Contributor Author

I'll look into the change further.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@neonene
Update NEWS
6635012
@neonene

neonene commented Dec 9, 2021

Copy link
Copy Markdown
Contributor Author

Additionally, I've posted an alternative PR (#30014) which leaves the instrumented folder as it is.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@neonene neonene closed this Dec 10, 2021
@neonene
neonene deleted the bpo-45582_pgo branch December 11, 2021 01:43
@zooba zooba mentioned this pull request Apr 10, 2022
Rewrite getpath.c in Python #89745
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@neonene @zooba @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.