GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "bpo-28533: Remove asyncore, asynchat, smtpd modules (GH-29521)" by vstinner · Pull Request #29951 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Dec 7, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit 9bf2cbc.

https://bugs.python.org/issue28533

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
Revert "bpo-28533: Remove asyncore, asynchat, smtpd modules (GH-29521)"
20e7506 
This reverts commit 9bf2cbc.
@vstinner
vstinner requested review from a team and vsajip as code owners December 7, 2021 08:12
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 7, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Dec 7, 2021
@vstinner vstinner mentioned this pull request Dec 7, 2021
Request PEP 387 exception for remove asyncore, asynchat and stmpd in Python 3.11 python/steering-council#86
Closed
@vstinner

vstinner commented Dec 7, 2021

Copy link
Copy Markdown
Member Author

PR related to the SC decision: python/steering-council#86
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
warsaw
warsaw approved these changes Dec 7, 2021
View reviewed changes
Comment thread Doc/library/socketserver.rst
particularly important for stream services where each client can potentially be
connected for a long time (if threads or subprocesses cannot be used). See
:mod:`asyncio` for another way to manage this.
:mod:`asyncore` for another way to manage this.

@warsaw warsaw Dec 7, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you still recommend asyncio even with the revert?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@vstinner vstinner Dec 7, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's possible, but I wanted to use a simple "git revert" command. Moreover, Miro wants to get it in 3.11.0a3, and Pablo suggests to merge the PR today, so I simply merged my PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Dec 7, 2021
vsajip
vsajip approved these changes Dec 7, 2021
View reviewed changes
@hroncok

hroncok commented Dec 7, 2021

Copy link
Copy Markdown
Contributor

@pablogsal Can we please include this in 3.11.0a3?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Dec 7, 2021

Copy link
Copy Markdown
Member

@pablogsal Can we please include this in 3.11.0a3?

Yup, but let's make sure It's merged today. We have a bunch of release blockers anyway :(
hroncok reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit cf7eaa4 into python:main Dec 7, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 7, 2021
@vstinner
vstinner deleted the restore_asyncore branch December 7, 2021 11:31
@Mariatta Mariatta mentioned this pull request Apr 11, 2022
Remove asyncore, asynchat and smtpd modules #72719
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip vsajip approved these changes
@warsaw warsaw warsaw approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@vstinner @hroncok @pablogsal @vsajip @warsaw @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.