GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43795: Document stable_abi.txt format and contents by encukou · Pull Request #29956 · python/cpython

Conversation

@encukou

@encukou encukou commented Dec 7, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

See discussion here: https://mail.python.org/archives/list/[email protected]/thread/64VOMHNR37N4HVPWAHKHJM4UFYJPVKSV/

(bpo-43795 is closed, but I think reusing it is OK for a comment-only change.)

https://bugs.python.org/issue43795

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@encukou
Document stable_abi.txt format and contents
7e1512a
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 7, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Dec 7, 2021
@encukou

encukou commented Dec 7, 2021

Copy link
Copy Markdown
Member Author

@gvanrossum, is this the comment you were looking for?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou encukou added the skip news label Dec 7, 2021
@tiran

tiran commented Dec 7, 2021

Copy link
Copy Markdown
Member

Petr, it would be helpful to explain under which circumstances an entry can be removed -- or that entries cannot be removed, even private _Py APIs.

pablogsal and encukou reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou
Link to more general documentation
97327d6
@encukou encukou mentioned this pull request Dec 7, 2021
Add guidelines for changing/removing from the Limited API python/devguide#778
Merged
@encukou

encukou commented Dec 7, 2021

Copy link
Copy Markdown
Member Author

That's a good idea, but IMO this comment should focus on the specifics of the stable_abi.txt file. So I added a link to the devguide, and I propose a new section there: python/devguide#778

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gvanrossum

gvanrossum commented Dec 7, 2021

Copy link
Copy Markdown
Member

That's a good idea, but IMO this comment should focus on the specifics of the stable_abi.txt file. So I added a link to the devguide, and I propose a new section there: python/devguide#778

Actually I think it should be stated here, in this file, as well. It is much more directly useful here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou
Mention that removals generally aren't allowed.
1867532
@encukou

encukou commented Dec 8, 2021

Copy link
Copy Markdown
Member Author

I summarized this as "Removing items from this file is generally not allowed, and additions should be considered with that in mind. See the devguide for exact rules."
Otherwise there'd be two fairly complex documents to keep in sync. Or it could all be moved to this file, but I think devguide is a better place.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gvanrossum
gvanrossum approved these changes Dec 8, 2021
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Dec 8, 2021
@ambv
ambv merged commit 98e506a into python:main Dec 10, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 10, 2021
@encukou
encukou deleted the document-stable_abi.txt branch December 14, 2021 13:50
@encukou encukou mentioned this pull request Jun 7, 2022
Implement PEP 652 -- Maintaining the Stable ABI #87961
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@encukou @tiran @gvanrossum @ambv @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.