GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45847: Don't override user overrides for CFLAGS/LIBS (GH-29967) by tiran · Pull Request #29967 · python/cpython

Conversation

@tiran

@tiran tiran commented Dec 7, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I'm deliberately using a more verbose approach here to make the code more understandable and easier to grep.

https://bugs.python.org/issue45847

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
tiran requested a review from erlend-aasland December 7, 2021 17:44
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 7, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Dec 7, 2021
@tiran tiran added the skip news label Dec 7, 2021
@tiran
tiran force-pushed the bpo-45847-fallback branch from b100d69 to 75d04da Compare December 7, 2021 17:46
erlend-aasland
erlend-aasland reviewed Dec 7, 2021
View reviewed changes
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland reviewed Dec 7, 2021
View reviewed changes
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
tiran added 4 commits December 8, 2021 09:36
@tiran
bpo-45847: Don't override user overrides for CFLAGS/LIBS
790bf15
@tiran
Only set LIBUUID flags on success
f77e1ff
@tiran
Strict failure on missing dependencies, too
4aec1ea
@tiran
Allow users to set empty flags
4cc2fe1
@tiran
tiran force-pushed the bpo-45847-fallback branch from 9e08520 to 4cc2fe1 Compare December 8, 2021 08:36
@tiran
tiran marked this pull request as ready for review December 8, 2021 08:37
erlend-aasland
erlend-aasland reviewed Dec 8, 2021
View reviewed changes
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tiran
More defaults
f02fae3
erlend-aasland
erlend-aasland approved these changes Dec 8, 2021
View reviewed changes
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 8, 2021
@bedevere-bot

bedevere-bot commented Dec 8, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit f02fae3 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 8, 2021
@tiran tiran changed the title bpo-45847: Don't override user overrides for CFLAGS/LIBS bpo-45847: Don't override user overrides for CFLAGS/LIBS (GH-29967) Dec 8, 2021
@tiran
tiran merged commit 0461c68 into python:main Dec 8, 2021
@tiran
tiran deleted the bpo-45847-fallback branch December 8, 2021 10:52
@bedevere-bot bedevere-bot removed the awaiting core review label Dec 8, 2021
@tiran tiran mentioned this pull request Apr 14, 2022
Port module setup to PY_STDLIB_MOD() macro and addext() #90005
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tiran @bedevere-bot @erlend-aasland @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.