GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45723: Normalise configure user communication (GH-30024) by erlend-aasland · Pull Request #30024 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Dec 10, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Normalise configure user communication; always use AC_MSG_* macros.

https://bugs.python.org/issue45723

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
bpo-45723: Use AC_MSG_* for all configure messages
29b437d
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 10, 2021
@erlend-aasland
erlend-aasland requested a review from tiran December 10, 2021 10:59
@bedevere-bot bedevere-bot added the awaiting review label Dec 10, 2021
@erlend-aasland erlend-aasland changed the title bpo-45723: Use AC_MSG_* for configure user communication bpo-45723: Normalise configure user communication Dec 10, 2021
@erlend-aasland erlend-aasland added the skip news label Dec 10, 2021
tiran
tiran approved these changes Dec 10, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Dec 10, 2021
@tiran

tiran commented Dec 10, 2021

Copy link
Copy Markdown
Member

Thanks!
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran tiran changed the title bpo-45723: Normalise configure user communication bpo-45723: Normalise configure user communication (GH-30024) Dec 10, 2021
@tiran
tiran merged commit 74b23c9 into python:main Dec 10, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 10, 2021
@erlend-aasland
erlend-aasland deleted the ac-msg branch December 10, 2021 11:29
erlend-aasland
erlend-aasland commented Dec 10, 2021
View reviewed changes
Comment thread configure.ac
if test -z "$ANDROID_API_LEVEL"; then
echo 'Fatal: you must define __ANDROID_API__'
exit 1
AC_MSG_ERROR([Fatal: you must define __ANDROID_API__])

@erlend-aasland erlend-aasland Dec 10, 2021

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, I forgot to remove the "Fatal: " prefix. I'll add it to a future autoconf PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran tiran mentioned this pull request Apr 22, 2022
Improve and simplify configure.ac checks #89886
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @tiran @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.