GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-89886: Use AC_CHECK_TYPES iso. AC_CHECK_TYPE by erlend-aasland · Pull Request #30029 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Dec 10, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

AC_CHECK_TYPE is deprecated.

Removed the __uint128_t check, as the define it produced is unused.

https://bugs.python.org/issue45723

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
bpo-45723: Use AC_CHECK_TYPES iso. AC_CHECK_TYPE
f6385ae 
AC_CHECK_TYPE is deprecated.

Removed the __uint128_t check, as it is unused.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 10, 2021
@erlend-aasland
erlend-aasland requested a review from tiran December 10, 2021 14:31
@bedevere-bot bedevere-bot added the awaiting review label Dec 10, 2021
@erlend-aasland erlend-aasland added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Dec 10, 2021
@bedevere-bot

bedevere-bot commented Dec 10, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit f6385ae 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 10, 2021
@github-actions

github-actions Bot commented Jan 10, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 10, 2022
MaxwellDupre
MaxwellDupre suggested changes Feb 21, 2022
View reviewed changes

@MaxwellDupre MaxwellDupre left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python executable created and tests look ok, but I see in config.log:
configure:19906: checking for socklen_t configure:19906: gcc -c conftest.c >&5 configure:19906: $? = 0 configure:19906: gcc -c conftest.c >&5 conftest.c: In function 'main': conftest.c:432:24: error: expected expression before ')' token 432 | if (sizeof ((socklen_t))) |

This looks like an issue.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Feb 21, 2022
@erlend-aasland erlend-aasland changed the title bpo-45723: Use AC_CHECK_TYPES iso. AC_CHECK_TYPE gh-89886: Use AC_CHECK_TYPES iso. AC_CHECK_TYPE Apr 10, 2022
@tiran tiran mentioned this pull request Apr 22, 2022
Improve and simplify configure.ac checks #89886
Closed
@erlend-aasland
Merge branch 'main' into ac-check-types
a24836a
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@erlend-aasland

erlend-aasland commented Jul 23, 2022

Copy link
Copy Markdown
Contributor Author

I don't have the bandwith to follow up this PR at the moment. Closing it for now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland closed this Jul 23, 2022
@erlend-aasland
erlend-aasland deleted the ac-check-types branch July 23, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran Awaiting requested review from tiran
1 more reviewer
@MaxwellDupre MaxwellDupre MaxwellDupre requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @bedevere-bot @MaxwellDupre @the-knights-who-say-ni @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.