GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46038: Mark /configure file as generated in .gitattributes by arhadthedev · Pull Request #30031 · python/cpython

Conversation

@arhadthedev

@arhadthedev arhadthedev commented Dec 10, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

configure is regenerated from configure.ac using a custom container with appropriate version of tools (quay.io/tiran/cpython_autoconf by Christian Heimes). As a result, configure falls into the same category as files generated by Argument Clinic, Freeze and Parser/asdl_c.py. Due to size and churn of these artifacts, they are marked in .gitattributes as generated so GitHub Pull Request Diff Viewer collapses them into a short notification. This pull request does the same for configure.

Actually, configure diff is so large that sometimes it crosses a threshold and GitHub collapses it by force with "Large diffs are not rendered by default" or even "xxx additions, yyy deletions not shown because the diff is too large. Please use a local Git client to view these changes". See GH-29756 as an extreme example and https://github.com/python/cpython/commits/main/configure for an average.

I believe this PR does not need a NEWS entry because the change is relevant only for a GitHub-hosted copy.

https://bugs.python.org/issue46038

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@arhadthedev
Mark configure file as generated in .gitattributes
85968c3 
configure is regenerated from configure.ac using a custom container
with appropriate version of tools (quay.io/tiran/cpython_autoconf
by Christian Heimes).

As a result, configure falls into the same category as files generated
by Argument Clinic, Freeze and Parser/asdl_c.py. Due to size and churn
of these artifacts, they are marked in .gitattributes as generated so
GitHub Pull Request Diff Viewer collapses them into a short
notification. This commit does the same for configure.

Actually, configure diff is so large that sometimes it crosses
a threshold and GitHub collapses it by force with "Large diffs are not
rendered by default" or even "xxx additions, yyy deletions not shown
because the diff is too large. Please use a local Git client to view
these changes". See pythonGH-29756 as an extreme example and
<https://github.com/python/cpython/commits/main/configure> for
an average.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 10, 2021
@bedevere-bot bedevere-bot added the awaiting review label Dec 10, 2021
@arhadthedev arhadthedev mentioned this pull request Dec 10, 2021
bpo-89886: Clean up MACHDEP and _PYTHON_HOST_PLATFORM checks #30026
Closed
tiran
tiran reviewed Dec 10, 2021
View reviewed changes
Comment thread .gitattributes Resolved

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev
Address review: mark aclocal.m4 as generated
2ade650
@tiran tiran added skip issue skip news and removed skip issue labels Dec 10, 2021
tiran
tiran approved these changes Dec 10, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Dec 10, 2021
erlend-aasland
erlend-aasland approved these changes Dec 10, 2021
View reviewed changes
@erlend-aasland

erlend-aasland commented Dec 10, 2021

Copy link
Copy Markdown
Contributor

I'd say we backport this to 3.10 and 3.9, @tiran.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Jan 10, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 10, 2022
taleinat
taleinat approved these changes Jan 18, 2022
View reviewed changes

@taleinat taleinat left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I know very little about autoconf.

@tiran, should this be merged? And should it be backported?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@arhadthedev

arhadthedev commented Jan 21, 2022

Copy link
Copy Markdown
Member Author

Closing in favor of #30745.
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev arhadthedev closed this Jan 21, 2022
@erlend-aasland erlend-aasland mentioned this pull request Jan 21, 2022
Update generated files list and add diff=generated attribute #30745
Merged
@arhadthedev
arhadthedev deleted the collapse-configure-in-pr branch February 2, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
+2 more reviewers
@tiran tiran tiran approved these changes
@taleinat taleinat taleinat approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@arhadthedev @erlend-aasland @tiran @taleinat @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.