GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45953: Statically allocate and initialize global bytes objects. by ericsnowcurrently · Pull Request #30096 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Dec 14, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The empty bytes object (b'') and the 256 one-character bytes objects are allocated at runtime init. Here we statically allocate and initialize them.

https://bugs.python.org/issue45953

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 4 commits December 13, 2021 18:08
@ericsnowcurrently
_Py_bytes_state -> _Py_global_objects.
18f6d44
@ericsnowcurrently
Statically initialize the empty bytes object.
8b96ac9
@ericsnowcurrently
Statically initialize the single character bytes objects.
dcac2ef
@ericsnowcurrently
Reset the hash when re-initializing.
bdae989
@ericsnowcurrently ericsnowcurrently added the skip news label Dec 14, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 14, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Dec 14, 2021
@ericsnowcurrently ericsnowcurrently mentioned this pull request Dec 14, 2021
fold _Py_bytes_state into _PyRuntimeState.global_objects.singletons faster-cpython/ideas#180
Closed
@ericsnowcurrently
ericsnowcurrently requested a review from markshannon December 14, 2021 01:25
markshannon
markshannon reviewed Dec 14, 2021
View reviewed changes
Comment thread Include/internal/pycore_global_objects.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
markshannon
markshannon reviewed Dec 14, 2021
View reviewed changes
Comment thread Include/internal/pycore_global_objects.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently
Drop _PyBytes_reset().
9c3dc1c
@ericsnowcurrently
ericsnowcurrently requested a review from markshannon December 27, 2021 18:57
markshannon
markshannon reviewed Jan 10, 2022
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few quibbles, otherwise looks good.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Include/internal/pycore_global_objects.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Include/internal/pycore_global_objects.h
.ob_shash = -1, \
.ob_sval[0] = '\0', \
}
#define _PyBytes_CHAR_INIT(CH) \

@markshannon markshannon Jan 10, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a declaration, not initialization code. Maybe rename to _PyBytes_CHAR?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ericsnowcurrently ericsnowcurrently Jan 10, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was sticking to the _INIT convention used elsewhere.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Objects/bytesobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/bytesobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
ericsnowcurrently added 2 commits January 10, 2022 16:29
@ericsnowcurrently
Use 255 instead of UCHAR_MAX.
86bee1c
@ericsnowcurrently
Factor out _PyBytes_SIMPLE_INIT().
dc88ef1
@ericsnowcurrently
ericsnowcurrently merged commit cf496d6 into python:main Jan 11, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Jan 11, 2022
@ericsnowcurrently
ericsnowcurrently deleted the global-objects-bytes branch January 11, 2022 16:37
@ericsnowcurrently ericsnowcurrently mentioned this pull request Nov 8, 2022
Statically allocate interpreter states as much as possible. #90111
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum left review comments
@markshannon markshannon markshannon left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ericsnowcurrently @gvanrossum @markshannon @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.