GeezerVison

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@DonaldDuck313

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

I have made the requested changes; please review again

Thanks for making the requested changes!

@asvetlov: please review the changes made to this pull request.

I have made the requested changes; please review again

Thanks for making the requested changes!

@asvetlov: please review the changes made to this pull request.

I have made the requested changes; please review again

You have not yet added any tests for your proposed new feature :) there's a guide to running and writing tests for CPython here: https://devguide.python.org/runtests/

@AlexWaygood I tried running python -m test as explained there and I got an error saying C:\ProgramData\Anaconda3\python.exe: No module named test.__main__; 'test' is a package and cannot be directly executed. I also tried from test import autotest but I got an error saying ImportError: cannot import name 'autotest' from 'test' (C:\ProgramData\Anaconda3\lib\test\__init__.py).

If you look carefully at the instructions on the devguide, the command starts with ./python, which makes your shell use the python you have built in the git repository, not your system python.

Tests for the module are here: https://github.com/python/cpython/blob/main/Lib/test/test_webbrowser.py

If you’re not sure how they are working, or how to test the lines you have added, you can ask on the core-mentorship mailing list and people will help.

@DonaldDuck313 it looks like you're in a conda virtual environment. You need to build CPython from the source in order to run the test suite with your changes applied. There's instructions on this page here on how to do that (a few pages prior to the instructions on running the tests): https://devguide.python.org/setup/

The following commit authors need to sign the Contributor License Agreement:

• [email protected]

This PR is stale because it has been open for 30 days with no activity.

This PR is blocked on its author, has not been touched by a human in more than 3 years, and no longer merges cleanly. Closing to cull the number of open pull requests. Do not reopen this pull request without getting a go-ahead from a triager or core developer on gh-90371.