GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||
GeezerVison is showing github.com — bpo-45292: [PEP-654] exception groups and except* documentation by iritkatriel · Pull Request #30158 · python/cpython Conversation
|
|
@willingc Is there anyone from the documentation experts who may be interested in helping with this? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@Fidget-Spinner Are you available to help here? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@iritkatriel I'm happy to help if @Fidget-Spinner is unavailable. I'm assuming you wish for some help to resolve whatever is causing the doc build to error. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Irit, this looks good. Looking into the keyword errors.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Thank you. Not just the formatting error, also a fresh reader who can see if it’s clear and consistent with the documentation style, and whether things are where they belong and at the right level of detail. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: Carol Willing <[email protected]>
|
@iritkatriel I think the tone and content are well done. I need to drop for the evening but feel free to merge if the build error resolves. Ping me in the morning if you get stuck on that. Thanks! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Hi @iritkatriel, you need to create a label/anchor (I forgot the term) for For some reason, keyword labels must be placed preceding a title, even though rST supports arbitrary anchors normally. See https://www.sphinx-doc.org/en/master/usage/restructuredtext/roles.html#role-ref for more info. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thank you @willingc and @Fidget-Spinner , it's looking good now. I will give @gvanrossum and @1st1 and anyone else a chance to review before merging. There isn't any rush with this - the early users we have now already read the PEP. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Wow! This is the first time I'm reading about PEP 654 in more detail, and I did not realize it was this powerful!
Speaking from the perspective of a newbie, I understood what you wrote. The tutorial and language reference is very clear to me.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Kumar Aditya <[email protected]>
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Kumar Aditya <[email protected]>
…that rest is not exactly subgroup(not condition)
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Kumar Aditya <[email protected]>
|
I'm happy to take comments related to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Shall I merge this? It might be nice to have the documentation there when except* is released in the next alpha. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@iritkatriel Prior to merging, can you recap any outstanding next actions needed in a message here. Thanks! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I believe this PR now describes the way exception groups and except* work, and is consistent with PEP654. The new |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I could also split out the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Yeah, let's keep |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Thank you everyone! The notes section is in this draft PR #30441. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.