GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — bpo-46119: Update bundled pip to 21.3.1 and setuptools to 59.7.0 by kumaraditya303 · Pull Request #30178 · python/cpython Conversation
|
|
cc @pablogsal |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hi @kumaraditya303. Thanks for your PR. Unfortunately I cannot merge this PR directly as I need to Will try to check this as soon as possible if @ambv doesn't do it first :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I am thinking about automating this step in cpython with a github action which runs every let's say a week or so and creates a PR with the latest pip and setuptools as manually it takes longer for pip to be updated in the repo and that will be more secure and fast rather than someone doing it. Let me know your thoughts on this @pablogsal |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
That would be a lot of unnecessary churns. We only need to update these pre-release, so technically once a month is ok. On the other hand this can be something done in the release itself. Maybe @ambv has some ideas here |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
We can add a unit test that gets hashes of pip and setuptools from Warehouse’s JSON API (e.g., https://pypi.org/pypi/pip/21.3.1/json) and compares it to hashes of the vendored files. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Ah, that would certainly be interesting! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Looks straight forward.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for the review but this is not ready to merge, there are now newer pip and setuptools versions (and possibly a new pip this week). Plus see earlier discussion on how to do this in a way to better fit with the release and avoid churn. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Closing as this is outdated now. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Done in #31885 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.