GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46119: Update bundled pip to 21.3.1 and setuptools to 59.7.0 by kumaraditya303 · Pull Request #30178 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Dec 18, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue46119

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@kumaraditya303
bpo-46119: Update bundled pip to 21.3.1 and setuptools to 59.7.0
8cfed85
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 18, 2021
@bedevere-bot bedevere-bot added the awaiting review label Dec 18, 2021
@blurb-it
📜🤖 Added by blurb_it.
934ce5d
@kumaraditya303

kumaraditya303 commented Dec 20, 2021

Copy link
Copy Markdown
Contributor Author

cc @pablogsal

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal

pablogsal commented Dec 20, 2021

Copy link
Copy Markdown
Member

Hi @kumaraditya303. Thanks for your PR.

Unfortunately I cannot merge this PR directly as I need to
validate the contents of the binary files included, as this is a potential security concern.

Will try to check this as soon as possible if @ambv doesn't do it first :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kumaraditya303

kumaraditya303 commented Dec 21, 2021

Copy link
Copy Markdown
Contributor Author

I am thinking about automating this step in cpython with a github action which runs every let's say a week or so and creates a PR with the latest pip and setuptools as manually it takes longer for pip to be updated in the repo and that will be more secure and fast rather than someone doing it.

Let me know your thoughts on this @pablogsal

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal

pablogsal commented Dec 21, 2021

Copy link
Copy Markdown
Member

uptools as manually it takes longer for pip to be updated in the repo and that will be more secure and fast rather than someone doing it.

That would be a lot of unnecessary churns. We only need to update these pre-release, so technically once a month is ok. On the other hand this can be something done in the release itself. Maybe @ambv has some ideas here

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@illia-v

illia-v commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

We can add a unit test that gets hashes of pip and setuptools from Warehouse’s JSON API (e.g., https://pypi.org/pypi/pip/21.3.1/json) and compares it to hashes of the vendored files.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal

pablogsal commented Dec 21, 2021

Copy link
Copy Markdown
Member

Ah, that would certainly be interesting!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions

github-actions Bot commented Jan 22, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 22, 2022
MaxwellDupre
MaxwellDupre approved these changes Feb 7, 2022
View reviewed changes

@MaxwellDupre MaxwellDupre left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straight forward.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Feb 7, 2022
@hugovk

hugovk commented Feb 7, 2022

Copy link
Copy Markdown
Member

Thanks for the review but this is not ready to merge, there are now newer pip and setuptools versions (and possibly a new pip this week).

Plus see earlier discussion on how to do this in a way to better fit with the release and avoid churn.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kumaraditya303

kumaraditya303 commented Feb 11, 2022

Copy link
Copy Markdown
Contributor Author

Closing as this is outdated now.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kumaraditya303 kumaraditya303 closed this Feb 11, 2022
@kumaraditya303
kumaraditya303 deleted the pip branch February 11, 2022 13:36
@illia-v

illia-v commented Mar 14, 2022

Copy link
Copy Markdown
Contributor

Ah, that would certainly be interesting!

Done in #31885

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@kumaraditya303 @pablogsal @illia-v @hugovk @MaxwellDupre @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.