GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43424: Deprecate `webbrowser.MacOSXOSAScript._name` attribute by sobolevn · Pull Request #30241 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Dec 23, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Changes:

  • Now all BaseBrowser subtypes have the same interface
  • I've also covered name in the docs, since original issue was about it

Looks like MacOSXOSAScript is not tested, so I didn't add any tests except local manual check:

Python 3.11.0a3+ (heads/main-dirty:71ef0b4c2b, Dec 23 2021, 12:38:09) [Clang 11.0.0 (clang-1100.0.33.16)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import webbrowser
>>> a = webbrowser.get()
>>> a.name
'default'
>>> a._name
<stdin>:1: DeprecationWarning: MacOSXOSAScript._name is deprecated in 3.11 use MacOSXOSAScript.name instead.
'default'
>>> a.open('https://python.org')
True

https://bugs.python.org/issue43424

Related python/typeshed#6673

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
bpo-43424: Deprecate webbrowser.MacOSXOSAScript._name attribute
5a73007
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 23, 2021
@bedevere-bot bedevere-bot added the awaiting review label Dec 23, 2021
sobolevn added 2 commits December 23, 2021 15:32
@sobolevn
Also include setter
17687be
@sobolevn
Add default value to name in __init__
9b7936c
@corona10
corona10 self-requested a review December 29, 2021 13:45
corona10
corona10 requested changes Dec 29, 2021
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpython/Lib/test/test_webbrowser.py

Line 307 in 77195cd

except (webbrowser.Error, AttributeError) as err:

We can now remove this skip section with this change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels Dec 29, 2021
@bedevere-bot

bedevere-bot commented Dec 29, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Remove AttributeError from test_webbrowser
8ec6955
@sobolevn

sobolevn commented Dec 29, 2021

Copy link
Copy Markdown
Member Author

@corona10 thank you! I've removed AttributeError from the list of allowed exceptions.
Because, I belive that webbrowser.Error can still happen on some platforms.

To make bot happy:
I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Dec 29, 2021
@bedevere-bot

bedevere-bot commented Dec 29, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from corona10 December 29, 2021 16:59
corona10
corona10 approved these changes Dec 30, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Dec 30, 2021
@corona10
corona10 merged commit d12bec6 into python:main Dec 30, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 30, 2021
@ilyagr ilyagr mentioned this pull request Dec 30, 2021
webconfig.py: minor polish of is_chromeos_garcon fish-shell/fish-shell#8596
Merged
2 of 3 tasks
@sobolevn

sobolevn commented Dec 30, 2021

Copy link
Copy Markdown
Member Author

@corona10 thank you! 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ilyagr ilyagr mannequin mentioned this pull request Apr 10, 2022
Document the controller.name field in webbrowser module #87590
Closed
@sobolevn sobolevn mentioned this pull request Jun 9, 2023
Remove deprecated MacOSXOSAScript._name attribute #105545
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @bedevere-bot @corona10 @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.