GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46219, 46221: simplify except* implementation following exc_info changes. Move helpers to exceptions.c. Do not assume that exception groups are truthy. by iritkatriel · Pull Request #30289 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Dec 29, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The functional except* changes were reviewed under PR30302 - I think they should be split out and not committed together with the POP_EXCEPT_AND_RERAISE change.

Otherwise, this just moves code from ceval.c to exceptions.c and sets me up to get a notification for PRs touching exceptions and tracebacks.

https://bugs.python.org/issue46221

https://bugs.python.org/issue46219

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
iritkatriel added 3 commits December 29, 2021 11:59
@iritkatriel
remove lasti from PREP_RERAISE_STAR. Do not use POP_EXCEPT_AND_RERAIS…
514b036 
…E for it
@iritkatriel
moved PREP_RERAISE_STAR helpers from ceval.c to exceptions.c
ee9f0f2
@iritkatriel
POP_JUMP_IF_TRUE --> JUMP_IF_TRUE_OR_POP
22c68a7
@iritkatriel
iritkatriel requested a review from gvanrossum December 29, 2021 14:37
@iritkatriel
iritkatriel requested a review from markshannon as a code owner December 29, 2021 14:37
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 29, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Dec 29, 2021
iritkatriel
iritkatriel commented Dec 29, 2021
View reviewed changes
Comment thread Python/ceval.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@blurb-it
📜🤖 Added by blurb_it.
1c05b92
@iritkatriel
iritkatriel marked this pull request as draft December 30, 2021 11:55
iritkatriel added 3 commits January 1, 2022 10:43
@iritkatriel
do not assume that an exception group is truthy
2a49fe9
@iritkatriel
update codeowners
4b39f20
@iritkatriel
change bpo
bfac878
@iritkatriel iritkatriel changed the title bpo-45711: simplify except star implementation following exc_info changes. Move PREP_RERAISE_STAR helpers to exceptions.c bpo-46219, 46221: simplify except* implementation following exc_info changes. Move helpers to exceptions.c. Do not assume that exception groups are truthy. Jan 1, 2022
iritkatriel added 2 commits January 1, 2022 14:22
@iritkatriel
Revert "📜🤖 Added by blurb_it."
46c8ea9 
This reverts commit 1c05b92.
@iritkatriel
add news
3e51647
@iritkatriel
iritkatriel marked this pull request as ready for review January 1, 2022 14:37
@iritkatriel
iritkatriel requested review from brandtbucher and ericsnowcurrently January 1, 2022 14:37
@iritkatriel

iritkatriel commented Jan 2, 2022

Copy link
Copy Markdown
Member Author

@erlend-aasland would you have time to review this? It’s mostly moving code from ceval.c to exceptions.c. Would be nice to get it into the next alpha release (due to be cut tomorrow) so it gets tested in close to final form.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes Jan 2, 2022
View reviewed changes

@erlend-aasland erlend-aasland left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked at the changes in ceval and the compiler with good help from Irit. LGTM. Moving exception helpers to exception.c is a nice "cleanup".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel

iritkatriel commented Jan 2, 2022

Copy link
Copy Markdown
Member Author

Thank you @erlend-aasland, @brandtbucher and @ericsnowcurrently for the reviews (on this an on PR30302 which contained the functional changes in this PR).
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
iritkatriel merged commit 65e7c1f into python:main Jan 2, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Jan 2, 2022
@iritkatriel
iritkatriel deleted the simplify-except-star branch January 13, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@brandtbucher brandtbucher Awaiting requested review from brandtbucher
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iritkatriel @erlend-aasland @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.