GeezerVison is showing github.com — bpo-46178: Remove/rename redundant Travis CI code by hugovk · Pull Request #30309 · python/cpython
Conversation
hugovk
commented
Dec 30, 2021
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Follow on from #30257, some extra Travis CI bits and bobs to remove or rename.
There's also a few extra places that added extra handling to catch random fails on Travis, I didn't touch those, but perhaps they could be reviewed/removed:
$ git grep -i travis
...
Lib/test/pythoninfo.py: # for device" on Travis CI
Lib/test/pythoninfo.py: "TRAVIS",
Lib/test/support/socket_helper.py: # with EADDRNOTAVAIL on Travis CI
Lib/test/support/socket_helper.py: # EADDRNOTAVAIL on Travis CI.
Lib/test/test_socket.py: # [bpo-33937](https://bugs.python.org/issue33937) the test randomly fails on Travis CI with
Lib/test/test_socket.py: # [bpo-33937](https://bugs.python.org/issue33937): catch also ENOMEM, the test randomly fails on Travis CI
...
https://bugs.python.org/issue46178
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
hugovk reacted with thumbs up emoji
|
@Mariatta: Please replace # with GH- in the commit message next time. Thanks!
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
Mariatta
Mariatta approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.