GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44136: pathlib: merge `_Flavour.make_uri()` into `PurePath.as_uri()` by barneygale · Pull Request #30320 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Jan 1, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Removes a bit of indirection.

https://bugs.python.org/issue44136

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@barneygale
bpo-44136: pathlib: merge _Flavour.make_uri() into PurePath.as_uri()
e3c29f7 
Removes a bit of indirection.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 1, 2022
@bedevere-bot bedevere-bot added the awaiting review label Jan 1, 2022
@github-actions

github-actions Bot commented Feb 1, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
barneygale reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 1, 2022
@barneygale
Delete duplicated docstring
94c41e5
@barneygale barneygale mentioned this pull request Feb 21, 2022
bpo-24132: Add pathlib._AbstractPath #31085
Closed
@brettcannon
brettcannon self-requested a review February 22, 2022 23:33
@brettcannon brettcannon added the skip news label Feb 25, 2022
@brettcannon brettcannon closed this Feb 25, 2022
@brettcannon brettcannon reopened this Feb 25, 2022
MaxwellDupre
MaxwellDupre approved these changes Feb 26, 2022
View reviewed changes

@MaxwellDupre MaxwellDupre left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Feb 26, 2022
@brettcannon

brettcannon commented Mar 4, 2022

Copy link
Copy Markdown
Member

So why do this? I noticed as_uri() wasn't moved under PurePosixPath, so why the half move? And what's going to be gained by doing this? I know the issue mentioned potential future benefits, but I would rather make the actual change with the future benefit rather than in hopes of the benefit materializing.

Basically the code doesn't read any simpler/cleaner, and with PurePosixPath not changed I'm not finding it more readable, so it feels a bit too much like code churn without understanding the deeper motivation.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale

barneygale commented Mar 4, 2022

Copy link
Copy Markdown
Contributor Author

Fair enough. I'll bundle this into a larger PR that has a more tangible benefit.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale barneygale closed this Mar 4, 2022
@barneygale barneygale mentioned this pull request Mar 4, 2022
bpo-44136: pathlib: merge _Flavour.is_reserved() into PurePath.is_reserved() #30321
Closed
@barneygale barneygale mannequin mentioned this pull request Jun 21, 2022
Remove pathlib flavours #88302
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon
1 more reviewer
@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@barneygale @brettcannon @MaxwellDupre @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.