GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-69093: Add incremental I/O to blobs support in `sqlite3` by erlend-aasland · Pull Request #30356 · python/cpython

Conversation

erlend-aasland commented Jan 3, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

TODO

Coverage: Test very large values (offsets > INT_MAX, etc.)
Finalise API (open_blob or blobopen?)

https://bugs.python.org/issue24905

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

palaviv and others added 30 commits

July 29, 2020 19:37


          support BLOB incremental I/O in sqlite module

4fa0e91


          Note that blob size cannot be changed using the blob object

3fe9108


          Use assertRaises in tests

865c1c8


          Fix doc error

788fd54


          blob support sequence protocol

a1361e5


          Calculate blob length once at creation

5aedfba


          Add initial Doc for sequence protocol

db6ef32


          Don't support blob operation

219f4cb


          move news entry to blurb

6dafe0e


          Add blob to PCBuild

ffac901


          Update version

3475fa1


          Fix memory leak

f6015ff


          Update version

01e526c


          Fix CR comments in documentation and testing

354bebf


          Fix CR comments in code


          Make readonly and dbname keyword arguements only

e6e5099


          Fix more CR comments

e9a8080


          Add more indicative error on write bigger then blob length

d4fb1b5


          Merge branch 'main' into sqlite-blob

a7288f9


          Adapt sqlite3.Connection.open_blob() to AC

525a9c3


          Adapt sqlite.Blob to AC

2f65cc8


          PEP 7 and normalised naming

0dd047f


          Use Py_NewRef and Py_IsNone

d34a77b


          Harden blob_open()

9d55705


          Move blob init to blob_open()

d47ea17


          initialise rc in blob_ass_subscript()

e07a116


          Improve blob.seek() parameter naming

982c812


          Adapt to heap types and allow calling close multiple times

e92495b


          Consolidate tests

8f2ce8a


          Naming: read_length => length

0a87520

Erlend E. Aasland added 7 commits

November 17, 2021 21:56


          Merge branch 'main' into sqlite-blob

220b576


          Format docs with linewidth 80

d9b5cdf


          Improve tests

aaa2721


          Merge branch 'main' into sqlite-blob

18e5118


          Add clinic_state() stub. (Currently not used)

8f685ba


          Visit/clear blob type during module traverse/clear

96df661


          Harden some tests, simplify others

97d12a8

the-knights-who-say-ni added the CLA signed label

Jan 3, 2022

bedevere-bot added the awaiting review label

Jan 3, 2022

erlend-aasland commented Jan 3, 2022

Copy link

Copy Markdown

Contributor Author

Original PR: GH-271
Original author: @palaviv

This PR is based on GH-271, with all changes applied on top of it. Thanks Aviv, for all the good work.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland added 14 commits

January 3, 2022 13:49


          Simplify example

2e63b3e


          Update docs

be27747

- sync with docstrings
- simplify some sections
- clarify some parameters


          Simplify tests

5add365


          Safe close

bacf087


          Condense a comment

5ff202d


          Make sure we catch int overflow for all types of writes

1fa5901


          Merge branch 'main' into sqlite-blob-all

16f4d0d


          Fix typo in test name

7aec288


          Improve test

aaaf7ab


          Improve tests

f9e65c0


          Always check length in inner write

6a5c864


          Fix missing array sentinel

ea1045c


          Match apsw's API open_blob => blobopen

2f848d9


          Fix overflow test on win x64

8d906bc

erlend-aasland mentioned this pull request

Jan 19, 2022

gh-69093: Support basic incremental I/O to blobs in sqlite3 #30680

Merged

erlend-aasland changed the title ~~bpo-24905: Add incremental I/O to blobs support in sqlite3~~ gh-69093: Add incremental I/O to blobs support in sqlite3

Apr 10, 2022

jimminter mannequin mentioned this pull request

Apr 15, 2022

Allow incremental I/O to blobs in sqlite3 #69093

Closed

JelleZijlstra commented Apr 15, 2022

Copy link

Copy Markdown

Member

@erlend-aasland can this be closed?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland closed this

Apr 15, 2022

erlend-aasland deleted the sqlite-blob branch

April 15, 2022 06:07

Reviewers

AA-Turner

Awaiting requested review from AA-Turner

AA-Turner will be requested when the pull request is marked ready for review

AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

erlend-aasland commented Jan 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

erlend-aasland commented Jan 3, 2022

Uh oh!

JelleZijlstra commented Apr 15, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

erlend-aasland commented Jan 3, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.