GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46257: Convert statistics._ss() to a single pass algorithm by rhettinger · Pull Request #30403 · python/cpython

Conversation

@rhettinger

@rhettinger rhettinger commented Jan 4, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue46257

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
rhettinger and others added 30 commits March 15, 2021 21:12
@rhettinger
Merge pull request #1 from python/master
bbd2da9 
Update to 15 March
@rhettinger
Merge branch 'master' of github.com:python/cpython
74bdf1b
@rhettinger
Merge branch 'master' of github.com:python/cpython
6c53f1a
@rhettinger
.
a487c4f 
Merge branch 'master' of github.com:python/cpython
@rhettinger
.
eb56423 
Merge branch 'master' of github.com:python/cpython
@rhettinger
.
cc7ba06 
Merge branch 'master' of github.com:python/cpython
@rhettinger
.
d024dd0 
Merge branch 'master' of github.com:python/cpython
@rhettinger
merge
b10f912 
Merge branch 'main' of github.com:python/cpython into main
@rhettinger
merge
fb6744d 
Merge branch 'main' of github.com:python/cpython
@rhettinger
Merge branch 'main' of github.com:python/cpython
7f21a1c
@rhettinger
Merge branch 'main' of github.com:rhettinger/cpython
7da42d4
@rhettinger
Merge branch 'main' of github.com:python/cpython
e31757b
@rhettinger
Merge branch 'main' of github.com:python/cpython
f058a6f
@rhettinger
Merge branch 'main' of github.com:python/cpython
1fc29bd
@rhettinger
Merge branch 'main' of github.com:python/cpython
e5c0184
@rhettinger
Merge branch 'main' of github.com:python/cpython
3c86ec1
@rhettinger
Merge branch 'main' of github.com:rhettinger/cpython
96675e4
@rhettinger
Merge branch 'main' of github.com:python/cpython
de558c6
@rhettinger
Merge branch 'main' of github.com:python/cpython
418a07f
@rhettinger
Merge branch 'main' of github.com:python/cpython
ea23a8b
@rhettinger
Merge branch 'main' of github.com:python/cpython
ba248b7
@rhettinger
Merge branch 'main' of github.com:python/cpython
9bc1df1
@rhettinger
Merge branch 'main' of github.com:python/cpython
d4466ba
@rhettinger
Merge branch 'main' of github.com:python/cpython
a89f02e
@rhettinger
Merge branch 'main' of github.com:python/cpython
aae9a5f
@rhettinger
Merge branch 'main' of github.com:python/cpython
7ba634b
@rhettinger
Add doctest and improve readability for move_to_end() example.
0b54723
@rhettinger
Single pass sum of squares
6ce943f
@rhettinger
Use len() to get the count
c8e2de7
@rhettinger
Avoid converting iterators to lists
45d83da
rhettinger added 2 commits January 4, 2022 10:42
@rhettinger
Neaten-up
b1a89be
@rhettinger
Add blurb
b4d2797
@rhettinger rhettinger added the performance Performance or resource usage label Jan 4, 2022
@rhettinger
rhettinger requested a review from stevendaprano January 4, 2022 17:06
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 4, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Jan 4, 2022
rhettinger and others added 2 commits January 4, 2022 09:10
@rhettinger
Avoid touching collections.rst
712f648
@rhettinger
Accumulate unsquared denominators
dc98276
tim-one
tim-one reviewed Jan 4, 2022
View reviewed changes

@tim-one tim-one left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check "the math" (that's impossible to get wrong 😉), but added some minor comments. Certainly approve of the idea.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/statistics.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/statistics.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
rhettinger and others added 6 commits January 4, 2022 09:25
@rhettinger @tim-one
Update Lib/statistics.py
6b2e8ca 
Co-authored-by: Tim Peters <[email protected]>
@rhettinger
Make mean() single pass over iterators
ae382ff
@rhettinger
Merge branch 'statistics_fast_ss' of github.com:rhettinger/cpython in…
2e03c7a 
…to statistics_fast_ss
@rhettinger
Update blurb to cover mean().
bbe6558
@rhettinger
Move _ss() into the private utilities section.
326bce8
@rhettinger
Use defaultdict() instead of boundmethod
208abcd
tim-one
tim-one reviewed Jan 5, 2022
View reviewed changes
Comment thread Lib/statistics.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@rhettinger
rhettinger merged commit 43aac29 into python:main Jan 5, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevendaprano stevendaprano Awaiting requested review from stevendaprano
1 more reviewer
@tim-one tim-one tim-one left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

performance Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@rhettinger @tim-one @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.