GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43137: Revert "webbrowser: Don't run gvfs-open on GNOME" by smcv · Pull Request #30417 · python/cpython

Conversation

@smcv

@smcv smcv commented Jan 5, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

gvfs-open was deprecated in 2015 and removed in 2018, but its replacement,
gio(1), is not available in Ubuntu 16.04, which is apparently still
supported by CPython upstream even though it is considered to be EOL by
Ubuntu developers.

https://bugs.python.org/issue43137

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@smcv
bpo-43137: Revert "webbrowser: Don't run gvfs-open on GNOME"
c5952f7
gvfs-open was deprecated in 2015 and removed in 2018, but its replacement,
gio(1), is not available in Ubuntu 16.04, which is apparently still
supported by CPython upstream even though it is considered to be EOL by
Ubuntu developers.

Signed-off-by: Simon McVittie <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 5, 2022
@bedevere-bot bedevere-bot added the awaiting review label Jan 5, 2022
@smcv

smcv commented Jan 5, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

As requested on https://bugs.python.org/issue43137 by @pablogsal. cc @tiran, @jaraco

I am not a CPython developer, so I cannot assess which reviewers' requirements are blockers and which are nice-to-have. Please agree on what you want from me, and then merge, or don't, as you prefer.

If the CPython infrastructure hadn't squashed the three commits in my original PR #29154 into a single commit, then this would have been easier (it's a revert of the last commit, aed1ba5).

If compatibility with truly ancient distros (pre-2008) is desired, you could also revert 251ea9c if you want, but I personally think that's a bad idea.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@smcv smcv mentioned this pull request Jan 5, 2022
bpo-43137: webbrowser: Replace gvfs-open and gnome-open with "gio open" #29154
Merged
@pablogsal pablogsal added the skip news label Jan 5, 2022
@pablogsal

pablogsal commented Jan 5, 2022

Copy link
Copy Markdown
Member

I am merging this to unblock the release.

@smcv Thanks for the original PR and for this revert. Please, check with @tiran about how to modify your original PR to ensure it works on all supported platforms.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal
pablogsal merged commit dd50316 into python:main Jan 5, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Jan 5, 2022
@smcv

smcv commented Jan 5, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Note that this is not a complete revert of #29154. I made three changes in #29154, and this PR only reverts the third one:

  • 4fd89aa: Prefer gio open over gvfs-open (this is the actual bug-fix for bpo-43137)
  • 251ea9c: Never invoke gnome-open (cleanup; breaks compatibility with approx. pre-2010 distros)
  • aed1ba5: Don't run gvfs-open on GNOME (cleanup; breaks compatibility with approx. pre-2016 distros; reverted in this PR)

I hope the end result, equivalent to applying 4fd89aa and 251ea9c but not aed1ba5, is acceptable to everyone.

If not, please tell me what would be acceptable. I have tried to be as clear as possible about what each commit does and why, so that reviewers can accept them or not as they prefer, but I don't know CPython development practices well enough to guess at what is required from me beyond that. Was I meant to submit these changes as three separate PRs that depended on each other, so that reviewers could accept the first one or two but reject the third if they wanted to?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@smcv @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.