GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40280: Disable epoll_create in Emscripten config.site (GH-30494) by emmatyping · Pull Request #30494 · python/cpython

Conversation

@emmatyping

@emmatyping emmatyping commented Jan 9, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

With the fix in 994f90c
building for Emscripten started failing with epoll link
errors as can be seen here:
https://github.com/ethanhs/python-wasm/runs/4745952720

I believe this shouldn't require a news entry.

https://bugs.python.org/issue40280

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@emmatyping
bpo-40280: Fix Emscripten build config.site
9d4553b 
With the fix in 994f90c
building for Emscripten started failing with epoll link
errors as can be seen here:
https://github.com/ethanhs/python-wasm/runs/4745952720
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 9, 2022
@bedevere-bot bedevere-bot added the awaiting review label Jan 9, 2022
@sobolevn sobolevn added the skip news label Jan 9, 2022
@sobolevn

sobolevn commented Jan 9, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@ethanhs should it be back-ported? 🤔

CC @corona10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10

corona10 commented Jan 9, 2022

Copy link
Copy Markdown
Member

@sobolevn
Supporting WASM is a new feature from Python 3.11
I don't think that the backport is needed.
sobolevn, erlend-aasland, and emmatyping reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes Jan 9, 2022
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Jan 9, 2022
@emmatyping

emmatyping commented Jan 9, 2022

Copy link
Copy Markdown
Member Author

Yes, since this is new in 3.11 there should be no need for any backporting.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jan 9, 2022

Copy link
Copy Markdown
Contributor

I'd update the PR title to more accurately reflect the actual change, though.
emmatyping reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@emmatyping emmatyping changed the title bpo-40280: Update Emscripten build config.site bpo-40280: Disable epoll_create in Emscripten config.site Jan 9, 2022
ngnpope
ngnpope suggested changes Jan 9, 2022
View reviewed changes
Comment thread Tools/wasm/config.site-wasm32-emscripten Resolved

Uh oh!

There was an error while loading. Please reload this page.
@emmatyping
Remove out of date line from config.site
0e96b83 
Co-authored-by: [email protected]
@emmatyping emmatyping mentioned this pull request Jan 9, 2022
bpo-40280: Add build target for Emscripten/node.js #30495
Closed
erlend-aasland
erlend-aasland approved these changes Jan 9, 2022
View reviewed changes
tiran
tiran approved these changes Jan 9, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jan 9, 2022
@tiran tiran changed the title bpo-40280: Disable epoll_create in Emscripten config.site bpo-40280: Disable epoll_create in Emscripten config.site (GH-30494) Jan 9, 2022
@tiran
tiran merged commit 5c66414 into python:main Jan 9, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 9, 2022
@SimonBiggs SimonBiggs mannequin mentioned this pull request Jun 7, 2022
Consider supporting emscripten/webassembly as a build target #84461
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
+2 more reviewers
@ngnpope ngnpope ngnpope requested changes
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@emmatyping @sobolevn @corona10 @erlend-aasland @tiran @ngnpope @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.