GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — Close stale PRs without signed CLA by erlend-aasland · Pull Request #30500 · python/cpython Conversation
|
|
FYI, we're "speed-testing" this PR over at https://github.com/hugovk/cpython/pulls |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@hugovk, based on the first cron run, I suggest the following changes:
Actually, I found the step with the "exempt rule" confusing to read compared to the step with the "only rule". It seems like the two rules are processed differently as well. For |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Debug output from the PR which was caught by the exempt-ruleDebug output from the PR which was caught by the only-ruleI prefer the latter. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
|
@Mariatta, thank you for reviewing! I've added the do-not-merge label until we've tested this change properly on our forks (see the last TODO item). I'll remove that label if everything is all fine after we've finished testing. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@hugovk, the logs look much better with the recent changes applied: https://github.com/hugovk/cpython/runs/4769591131?check_suite_focus=true |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I've tested this change on my fork, modified to mark a PR stale after 1 day, and close after 1 day (no CLA). I've verified, as expected, that PRs that are marked stale, and that received comments after being marked stale, will not be closed (cc. @ambv). For test PR 20, which received comments after being marked stale, the actions bot correctly removed the stale label on the following run. For test PR 21, which did not receive comments after being marked stale, the actions bot closed the PR on the following run. Here's the PRs:
(Removing the do-not-merge label, @Mariatta.) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@ambv Are ok with this PR as it stands? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@erlend-aasland yes, let's land it. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.