GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46315: Add ifdef HAVE_ feature checks for WASI compatibility (GH-30507) by tiran · Pull Request #30507 · python/cpython

Conversation

@tiran

@tiran tiran commented Jan 9, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • add check for HAVE_CLOCK
  • use HAVE_PTHREAD_H to guard include of pthread.h
  • guard getpid() with HAVE_GETPID
  • guard clock() with HAVE_CLOCK
  • add checks for HAVE_UMASK and HAVE_CHMOD
  • guard include of setjmp.h
  • use signal emulation on WASI

https://bugs.python.org/issue46315

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
tiran requested review from a team and rhettinger as code owners January 9, 2022 18:46
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 9, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Jan 9, 2022
erlend-aasland
erlend-aasland approved these changes Jan 9, 2022
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
bpo-46315: Add ifdef HAVE_ feature checks for WASI compatibility
859bbbc 
* add check for HAVE_CLOCK
* use HAVE_PTHREAD_H to guard include of pthread.h
* guard getpid() with HAVE_GETPID
* guard clock() with HAVE_CLOCK
* add checks for HAVE_UMASK and HAVE_CHMOD
* guard include of setjmp.h
* use signal emulation on WASI
@tiran
tiran force-pushed the bpo-46315-wasi branch from ed29753 to 859bbbc Compare January 12, 2022 23:13
@tiran tiran changed the title bpo-46315: Add ifdef HAVE_ feature checks for WASI compatibility bpo-46315: Add ifdef HAVE_ feature checks for WASI compatibility (GH-30507) Jan 13, 2022
@tiran
tiran merged commit a6ca8ee into python:main Jan 13, 2022
@tiran
tiran deleted the bpo-46315-wasi branch January 13, 2022 08:46
@bedevere-bot bedevere-bot removed the awaiting core review label Jan 13, 2022
@tiran tiran mentioned this pull request Oct 4, 2022
Add support for WebAssembly System Interface (wasm32-wasi) #90473
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tiran @erlend-aasland @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.