GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40280: Add --with-emscripten-target to build for browser or node (GH-30552) by tiran · Pull Request #30552 · python/cpython

Conversation

@tiran

@tiran tiran commented Jan 11, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Co-authored-by: Ethan Smith [email protected]
Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue40280

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 11, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Jan 11, 2022
@tiran @emmatyping
bpo-40280: Add --with-emscripten-target to build for browser or node
b5b4504 
Co-authored-by: Ethan Smith <[email protected]>
Signed-off-by: Christian Heimes <[email protected]>
@tiran
tiran force-pushed the bpo-40280-emscripten-targets branch from a1aab67 to b5b4504 Compare January 11, 2022 23:46
tiran added 3 commits January 12, 2022 00:55
@tiran
Fix typo
ada381a
@tiran
Skip xxlimited on Emscripten
6ba424c
@tiran
Create pybuilddir.txt for make python.js
259effe
emmatyping
emmatyping reviewed Jan 12, 2022
View reviewed changes
Comment thread configure Resolved

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon
brettcannon self-requested a review January 12, 2022 01:08
emmatyping
emmatyping reviewed Jan 12, 2022
View reviewed changes
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
emmatyping
emmatyping approved these changes Jan 12, 2022
View reviewed changes

@emmatyping emmatyping left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions but otherwise this looks good! It is a bit unfortunate that running emmake make after the correct configure doesn't "just work" but alas.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
tiran added 2 commits January 12, 2022 09:27
@tiran
Build python.wasm on WASI
12938c3
@tiran
make / make all now works, too
dcccfae
@tiran

tiran commented Jan 12, 2022

Copy link
Copy Markdown
Member Author

Two suggestions but otherwise this looks good! It is a bit unfortunate that running emmake make after the correct configure doesn't "just work" but alas.

It does now :)
emmatyping reacted with hooray emoji emmatyping reacted with rocket emoji
All reactions
  • 🎉 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran
tiran marked this pull request as ready for review January 12, 2022 09:01
tiran added 2 commits January 12, 2022 10:19
@tiran
Regenerate
6ddc9d3
@tiran
blurb
0f405fe
@tiran tiran mentioned this pull request Jan 12, 2022
Results of running the regression test suite on nodejs emmatyping/python-wasm#41
Closed
@tiran
clock_nanosleep does not work in Emscripten
52c0547
@tiran tiran changed the title bpo-40280: Add --with-emscripten-target to build for browser or node bpo-40280: Add --with-emscripten-target to build for browser or node (GH-30552) Jan 12, 2022
@tiran
tiran merged commit 43839ba into python:main Jan 12, 2022
@tiran
tiran deleted the bpo-40280-emscripten-targets branch January 12, 2022 15:08
@bedevere-bot bedevere-bot removed the awaiting core review label Jan 12, 2022
This was referenced Jan 12, 2022
bpo-40280: Add build target for Emscripten/node.js #30495
Closed
Emscripten build with NODERAWFS=1 emmatyping/python-wasm#36
Closed
Modify heap size or allow heap growth emmatyping/python-wasm#29
Closed
@SimonBiggs SimonBiggs mannequin mentioned this pull request Jun 7, 2022
Consider supporting emscripten/webassembly as a build target #84461
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmatyping emmatyping emmatyping approved these changes
@brettcannon brettcannon Awaiting requested review from brettcannon

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tiran @emmatyping @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.