GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-46070: Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)" by vstinner · Pull Request #30566 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jan 12, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit 7247407.

Fix a random crash involving subinterpreters on Windows. Revert the
change which made the gc module state per interpreter: the gc module
state is shared again by all interpreters.

https://bugs.python.org/issue36854

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner requested a review from pablogsal as a code owner January 12, 2022 23:02
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 12, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Jan 12, 2022
@vstinner
vstinner requested review from brettcannon, encukou, ericsnowcurrently, ncoghlan and warsaw as code owners January 12, 2022 23:07
@vstinner
bpo-46070: Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterprete…
2096c10 
…rState (GH-17287)"

This reverts commit 7247407.

Fix a random crash involving subinterpreters on Windows. Revert the
change which made the gc module state per interpreter: the gc module
state is shared again by all interpreters.
@vstinner vstinner changed the title [3.9] Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)" bpo-46070: [3.9] Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)" Jan 12, 2022
ericsnowcurrently
ericsnowcurrently approved these changes Jan 12, 2022
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jan 12, 2022
vstinner added 2 commits January 13, 2022 00:52
@vstinner
Fix the ABI
d400a3b
@vstinner
Second ABI fix: add again PyAPI_FUNC() on _PyGC_InitState()
d0aa809
@vstinner vstinner changed the title bpo-46070: [3.9] Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)" [3.9] bpo-46070: Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)" Jan 13, 2022
@vstinner

vstinner commented Jan 13, 2022

Copy link
Copy Markdown
Member Author

Without this PR, I can crash Python in a reliable way using this method: https://bugs.python.org/issue46070#msg410447

With this PR, I can no longer reproducer the crash: Python is fixed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon
brettcannon removed their request for review January 13, 2022 01:02
@vstinner

vstinner commented Jan 13, 2022

Copy link
Copy Markdown
Member Author

I wrote a simpler fix: GH-30577.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Jan 13, 2022
@vstinner
vstinner deleted the revert_gc39 branch January 13, 2022 18:31
@graysky graysky mannequin mentioned this pull request Apr 10, 2022
[subinterpreters] crash when importing _sre in subinterpreters in parallel (Python 3.9 regression) #90228
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@encukou encukou Awaiting requested review from encukou encukou is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @ericsnowcurrently @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.