GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update tty.py: Partially added type hints and changed wildcard import to only needed parts by USLTD · Pull Request #30581 · python/cpython

Conversation

@USLTD

@USLTD USLTD commented Jan 13, 2022

Copy link
Copy Markdown

Partially added type hints and instead of wildcard importing import only needed parts

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Luka Mamukashvili
Update tty.py
8816451
Partially added type hints and instead of wildcard importing import only needed parts
@the-knights-who-say-ni

the-knights-who-say-ni commented Jan 13, 2022

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@UltraStudioLTD

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Jan 13, 2022
@bedevere-bot bedevere-bot added the awaiting review label Jan 13, 2022
@AlexWaygood

AlexWaygood commented Jan 13, 2022

Copy link
Copy Markdown
Member

Hi, and welcome to CPython!

It's not really clear to me what this PR addresses, I'm afraid — you haven't really stated what problems there are with the existing module that your PR is trying to solve. Please also note that type hints are very rarely added to the standard library — if you want to help work on type hints, I'd recommend heading over to https://github.com/python/typeshed, where PRs are very welcome 😀

I'm afraid there are some other issues with this PR, too. For the CPython repo, almost every PR (unless it's doing something extremely trivial, like fixing a documentation typo) should be linked to an issue ticket on bugs.python.org. Lastly, and most importantly, you're unfortunately attempting to merge this PR into the 3.10 branch. For CPython, almost all changes are first made to the main branch (which currently represents the as-yet-unreleased Python 3.11), and then backported to maintenance branches if necessary. In order to have your ideas considered, you would have to close this PR and file a new one against the main branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlexWaygood AlexWaygood added the invalid label Jan 13, 2022
@USLTD USLTD closed this Jan 13, 2022
@USLTD
USLTD deleted the patch-1 branch February 2, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@USLTD @the-knights-who-say-ni @AlexWaygood @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.