GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40280: Skip subprocess-based tests on wasm32-emscripten (GH-30615) by tiran · Pull Request #30615 · python/cpython

Conversation

@tiran

@tiran tiran commented Jan 15, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue40280

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 15, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Jan 15, 2022
kumaraditya303
kumaraditya303 reviewed Jan 15, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Tests/2022-01-14-23-22-41.bpo-40280.nHLWoD.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tiran
tiran force-pushed the bpo-40280-test-subprocess branch from e61311a to 87fd2fe Compare January 16, 2022 22:03
emmatyping
emmatyping reviewed Jan 17, 2022
View reviewed changes
Comment thread Lib/test/support/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tiran
tiran force-pushed the bpo-40280-test-subprocess branch 2 times, most recently from 61decef to 8c9097e Compare January 21, 2022 15:38
@tiran
bpo-40280: Skip subprocess tests on wasm32-emscripten / wasi
d20fdb2
@tiran
tiran force-pushed the bpo-40280-test-subprocess branch from 8c9097e to d20fdb2 Compare January 24, 2022 08:19
@tiran
tiran marked this pull request as ready for review January 24, 2022 08:52
@tiran
tiran requested review from gpshead, iritkatriel and vsajip as code owners January 24, 2022 08:52
gpshead
gpshead reviewed Jan 24, 2022
View reviewed changes
Comment thread Lib/lib2to3/tests/test_parser.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/support/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
gpshead
gpshead approved these changes Jan 25, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jan 25, 2022
emmatyping
emmatyping approved these changes Jan 25, 2022
View reviewed changes

@emmatyping emmatyping left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran tiran changed the title bpo-40280: Skip subprocess-based tests on wasm32-emscripten bpo-40280: Skip subprocess-based tests on wasm32-emscripten (GH-30615) Jan 25, 2022
@tiran
tiran merged commit 8464fbc into python:main Jan 25, 2022
@tiran
tiran deleted the bpo-40280-test-subprocess branch January 25, 2022 07:09
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 25, 2022
@SimonBiggs SimonBiggs mannequin mentioned this pull request Jun 7, 2022
Consider supporting emscripten/webassembly as a build target #84461
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments
@gpshead gpshead gpshead approved these changes
@emmatyping emmatyping emmatyping approved these changes
@iritkatriel iritkatriel Awaiting requested review from iritkatriel
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@tiran @gpshead @emmatyping @kumaraditya303 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.