GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43683: Streamline YIELD_VALUE and SEND by markshannon · Pull Request #30723 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Jan 20, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Adds a new opcode ASYNC_GEN_WRAP, so that YIELD_VALUE does not need to special case async generators.
Doing so allows us to simplify SEND as it no longer sends and yields, just sends.

https://bugs.python.org/issue43683

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
markshannon added 5 commits January 20, 2022 15:12
@markshannon
Split YIELD_VALUE into ASYNC_GEN_WRAP; YIELD_VALUE for async generators.
cd876bc
@markshannon
Split SEND into SEND; YIELD_VALUE.
3e85ca2
@markshannon
Document new opcodes.
27bb797
@markshannon
Add news item.
f642591
@markshannon
Correct issue number in news item.
175bd7c
@markshannon
markshannon requested a review from 1st1 as a code owner January 20, 2022 17:18
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 20, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Jan 20, 2022
@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 21, 2022
@bedevere-bot

bedevere-bot commented Jan 21, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 175bd7c 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 21, 2022
@markshannon

markshannon commented Jan 24, 2022

Copy link
Copy Markdown
Member Author

Buildbot failures are unrelated to this PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@markshannon
markshannon merged commit 0367a36 into python:main Jan 24, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Jan 24, 2022
@markshannon markshannon mentioned this pull request Sep 13, 2022
Handle generator (and coroutine) state in the bytecode. #87849
Closed
@markshannon
markshannon deleted the more-yield-changes branch September 26, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@markshannon @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.