GeezerVison is showing github.com — bpo-46504: faster code for trial quotient in x_divrem() by tim-one · Pull Request #30856 · python/cpython
Conversation
tim-one
commented
Jan 24, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
This brings x_divrem() back into synch with x_divrem1(), which was changed
in bpo-46406 to generate faster code to find machine-word division
quotients and remainders. Modern processors compute both with a single
machine instruction, but convincing C to exploit that requires writing
less "clever" C code.
https://bugs.python.org/issue46504
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This brings x_divrem() back into synch with x_divrem1(), which was changed
in bpo-46406 to generate faster code to find machine-word division
quotients and remainders. Modern processors compute both with a single
machine instructioh, but convincing C to exploit that requires writing
_less_ "clever" C code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The macOS GitHub Actions failure looks unrelated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
tim-one reacted with thumbs up emoji
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
gpshead
gpshead left review comments
+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.