GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40077: Convert _pickle module to use heap types. by CharlieZhao95 · Pull Request #30884 · python/cpython

Conversation

@CharlieZhao95

@CharlieZhao95 CharlieZhao95 commented Jan 25, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Replace statically allocated types in _pickle module with heap allocated types:
use PyType_FromModuleAndSpec().

https://bugs.python.org/issue40077

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
CharlieZhao95 added 5 commits January 24, 2022 10:21
@CharlieZhao95
Replace Pickler_Type & Unpickler_Type with heap allocated types:
4a8a3e7 
use PyType_FromSpec().
@CharlieZhao95
Fix ref.leak in Pickler & Unpickler
f5f0d39
@CharlieZhao95
Convert _pickle module to use PyType_FromModuleAndSpec()
ae949a1
@CharlieZhao95
Add heap types to traverse, clear and free functions
2905ef4
@CharlieZhao95
Replace find_pickle_state_by_type() with get_pickle_state_by_class()
6df22b4
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 25, 2022
@bedevere-bot bedevere-bot added the awaiting review label Jan 25, 2022
@blurb-it
📜🤖 Added by blurb_it.
e3d2f18
@vstinner

vstinner commented Jan 25, 2022

Copy link
Copy Markdown
Member

Sadly, for now, converting static types to heap types is stale: https://bugs.python.org/issue40077#msg411630
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@CharlieZhao95

CharlieZhao95 commented Jan 26, 2022

Copy link
Copy Markdown
Contributor Author

Sadly, for now, converting static types to heap types is stale: https://bugs.python.org/issue40077#msg411630

Thanks for your reply! I'll keep this branch around and await to get permission from SC to continue with these changes.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@CharlieZhao95 CharlieZhao95 closed this Jan 26, 2022
@erlend-aasland

erlend-aasland commented Jan 28, 2022

Copy link
Copy Markdown
Contributor

FYI: python/steering-council#99
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303

kumaraditya303 commented Mar 10, 2022

Copy link
Copy Markdown
Contributor

FYI: python/steering-council#99

@erlend-aasland What is the current status now? Should more extension modules be ported or not ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Mar 10, 2022

Copy link
Copy Markdown
Contributor

Petr and I are working on a PEP. When it is ready for review, we'll post it on Discourse/python-dev. When all comments have been addressed, we'll submit it to the SC and wait for either acceptance or rejection. I don't think there will be a change of status in the 3.11 development frame.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 mentioned this pull request Jun 27, 2022
Convert static types to heap types: use PyType_FromSpec() #84258
Closed
@CharlieZhao95 CharlieZhao95 mentioned this pull request Mar 30, 2023
Isolate Stdlib Extension Modules #103092
Closed
24 of 25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@CharlieZhao95 @vstinner @erlend-aasland @kumaraditya303 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.