GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40280: Use presence of msvcrt module to detect Windows by tiran · Pull Request #30930 · python/cpython

Conversation

@tiran

@tiran tiran commented Jan 26, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue40280

Automerge-Triggered-By: GH:tiran

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
bpo-40280: Use presence of msvcrt module to detect Windows
0bf70c4
@tiran
tiran requested a review from zware January 26, 2022 22:23
@tiran
tiran requested a review from gpshead as a code owner January 26, 2022 22:23
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 26, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Jan 26, 2022
@tiran tiran mentioned this pull request Jan 26, 2022
bpo-40280: Change subprocess imports for cleaner error on wasm32 (GH-30620) #30620
Merged
zware
zware approved these changes Jan 26, 2022
View reviewed changes

@zware zware left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jan 26, 2022
@zware

zware commented Jan 26, 2022

Copy link
Copy Markdown
Member

The NEWS entry from GH-30620 will need some rewording.
gpshead and tiran reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran
Update news entry
fa83328
gpshead
gpshead approved these changes Jan 27, 2022
View reviewed changes
@tiran tiran added the 🤖 automerge label Jan 27, 2022
@miss-islington
miss-islington merged commit 606e496 into python:main Jan 27, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 27, 2022
@SimonBiggs SimonBiggs mannequin mentioned this pull request Jun 7, 2022
Consider supporting emscripten/webassembly as a build target #84461
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@zware zware zware approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@tiran @zware @gpshead @the-knights-who-say-ni @bedevere-bot @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.